[JIRA] (IDP-1961) Allow custom HttpClient for IdP update (e.g. HTTP Proxy)

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1961 ( https://shibboleth.atlassian.net/browse/IDP-1961?atlOrigin=eyJpIjoiNjdmZTFjNWVkODEyNGRhMDgwZmQxNmIxNjI0ZmYwYmIiLCJwIjoiaiJ9 )

Re: Allow custom HttpClient for IdP update (e.g. HTTP Proxy) ( https://shibboleth.atlassian.net/browse/IDP-1961?atlOrigin=eyJpIjoiNjdmZTFjNWVkODEyNGRhMDgwZmQxNmIxNjI0ZmYwYmIiLCJwIjoiaiJ9 )

I think that there are three issues at play here

* You want the IdP to have all the common CLI options. The Installer predates the common CLI (and indeed is still heavily ANT based). If we decide to refactor the installer in V5 it will be on top of the common CLI. TBH all Installers are never anything other than nasty and bitty so I always want to refactor them (“Surely it won’t be as bad this time” - but it always is)
* The reason why you want the Installer to have the common CLI options is that you want to inject a HttpClient. But the installer doesn’t use an HttpClient.
* You want the IdP to discover all the plugins and update them. I like the general idea but I’m not sure I want to make the (already) horrendously complex IdP Installer more complicated (particularly since you get told to update the plugins and each one can be updated with one command line prior to deploying the war).
However If you put in an RFE for that it will get some attention during the V5 lifetime.

( https://shibboleth.atlassian.net/browse/IDP-1961#add-comment?atlOrigin=eyJpIjoiNjdmZTFjNWVkODEyNGRhMDgwZmQxNmIxNjI0ZmYwYmIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1961#add-comment?atlOrigin=eyJpIjoiNjdmZTFjNWVkODEyNGRhMDgwZmQxNmIxNjI0ZmYwYmIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100200- sha1:9199305 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220613/72f7cda1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-14d15477-a438-4e8e-afe2-903859cdf8fc
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220613/72f7cda1/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c5b92cbc-f36e-4bbd-9f37-87bfa7cb36c2
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220613/72f7cda1/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-64d5a493-5e93-45bc-9058-770f34915447
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220613/72f7cda1/attachment-0005.png>