[JIRA] (IDP-1793) Use Suppliers for HttpRequest/Response

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1793 ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiMGJiN2NiNTk0Y2JkNDk1NGI3NzE5NWRjMzA3YjY2NGYiLCJwIjoiaiJ9 )

Re: Use Suppliers for HttpRequest/Response ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiMGJiN2NiNTk0Y2JkNDk1NGI3NzE5NWRjMzA3YjY2NGYiLCJwIjoiaiJ9 )

Working through the Actions (on a dev branch) where working through means looking at all the places where we call the setter (in idp-conf-impl), then reviewing the use (to make sure that the request isn't being stored) and then changing to the Supplier setter.

This is all helping to convince myself that (at least) this should be done. I’ll look at the other uses in the next pass.

But as I do this I am wondering about the plugins and whether we need to leave the legacy setter in place so that they can carry on working in V5, but I am also wondering whether there is not some smarts we can do in spring to detect if the the supplier if its present ( #getBean('shibboleth.HttpRequestSupplier') ) and if it isn’t calling the old setter (or some such)

( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiMGJiN2NiNTk0Y2JkNDk1NGI3NzE5NWRjMzA3YjY2NGYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiMGJiN2NiNTk0Y2JkNDk1NGI3NzE5NWRjMzA3YjY2NGYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:82b4599 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/523b0f49/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-24e55ae0-578c-4c9d-b22d-15f053479d00
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/523b0f49/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c822bf1f-6220-4c9e-9886-ff6d6b01b133
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/523b0f49/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-74e774ab-98d7-4d56-bad7-3368e1d0d28a
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/523b0f49/attachment-0005.png>