[JIRA] (IDP-1987) Review net.shibboleth.idp.authn.impl.ExtractX509CertificateFromRequest

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiYjQxYjBiZTRmZjIyNDQ3NDlkYmFmMTQ2NzhiZDAxYjciLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/IDP-1987?atlOrigin=eyJpIjoiYjQxYjBiZTRmZjIyNDQ3NDlkYmFmMTQ2NzhiZDAxYjciLCJwIjoiaiJ9 ) IDP-1987 ( https://shibboleth.atlassian.net/browse/IDP-1987?atlOrigin=eyJpIjoiYjQxYjBiZTRmZjIyNDQ3NDlkYmFmMTQ2NzhiZDAxYjciLCJwIjoiaiJ9 ) Review net.shibboleth.idp.authn.impl.ExtractX509CertificateFromRequest ( https://shibboleth.atlassian.net/browse/IDP-1987?atlOrigin=eyJpIjoiYjQxYjBiZTRmZjIyNDQ3NDlkYmFmMTQ2NzhiZDAxYjciLCJwIjoiaiJ9 )

Issue Type: Task Affects Versions: 5.0.0 Assignee: Unassigned Components: Authentication Created: 30/Jul/22 10:07 AM Fix Versions: 5.0.0 Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

As I’m working through https://shibboleth.atlassian.net/browse/IDP-1793 I’m reading prety much every use of HttpServletRequest and HttpServerletResponse. While doing that I spotted a couple of potential issues with this class

* V5.0 would be a good time to swap the order of lookup from getAttribute("javax.servlet.request.X509Certificate"); to getAttribute("jakarta.servlet.request.X509Certificate");
* It uses a couple of deprecated X509Certificate getters.

I know nothing about this stuff so I am not the person to do the work (or close this case as “wont do”)

( https://shibboleth.atlassian.net/browse/IDP-1987#add-comment?atlOrigin=eyJpIjoiYjQxYjBiZTRmZjIyNDQ3NDlkYmFmMTQ2NzhiZDAxYjciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1987#add-comment?atlOrigin=eyJpIjoiYjQxYjBiZTRmZjIyNDQ3NDlkYmFmMTQ2NzhiZDAxYjciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:82b4599 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/76ecf084/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-910e9036-6c14-4c9a-9ac4-a990744e4460
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/76ecf084/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-716348d0-b6ed-4506-b289-32d58e79d176
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/76ecf084/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4932935d-cdcf-4ac6-a4cb-04046ec0b8c8
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/76ecf084/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-a78c8f58-eb46-4e16-a45c-fbb20297f366
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220730/76ecf084/attachment-0007.png>