[JIRA] (OSJ-357) Scratch context map is abusing generics

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

OpenSAML - Java ( https://shibboleth.atlassian.net/browse/OSJ?atlOrigin=eyJpIjoiMTIzNjkxOGU5MjgyNDA3OGEyNGRjZjU5YzM4YTU0OWEiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/OSJ-357?atlOrigin=eyJpIjoiMTIzNjkxOGU5MjgyNDA3OGEyNGRjZjU5YzM4YTU0OWEiLCJwIjoiaiJ9 ) OSJ-357 ( https://shibboleth.atlassian.net/browse/OSJ-357?atlOrigin=eyJpIjoiMTIzNjkxOGU5MjgyNDA3OGEyNGRjZjU5YzM4YTU0OWEiLCJwIjoiaiJ9 ) Scratch context map is abusing generics ( https://shibboleth.atlassian.net/browse/OSJ-357?atlOrigin=eyJpIjoiMTIzNjkxOGU5MjgyNDA3OGEyNGRjZjU5YzM4YTU0OWEiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.0.0, 4.0.1, 4.1.0, 4.1.1, 4.2.0 Assignee: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) Created: 29/Jul/22 10:23 AM Fix Versions: 4.3.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

The ScratchContext was typed with a Map<?,?> and that’s wrong. It should be <Object,Object>, as the wildcards imply the types are fixed but just not set, so you can’t really interact with it in Java code properly, you get capture mismatches.

( https://shibboleth.atlassian.net/browse/OSJ-357#add-comment?atlOrigin=eyJpIjoiMTIzNjkxOGU5MjgyNDA3OGEyNGRjZjU5YzM4YTU0OWEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-357#add-comment?atlOrigin=eyJpIjoiMTIzNjkxOGU5MjgyNDA3OGEyNGRjZjU5YzM4YTU0OWEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:82b4599 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220729/5e246786/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0c1e27dd-b6a8-4522-9833-bc6769e5b1d3
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220729/5e246786/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-f8b1106e-5d64-477e-9bff-48d9001104bf
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220729/5e246786/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-9372ff61-6a21-4e14-9cf7-6247194fbd85
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220729/5e246786/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-cd53f56f-d43f-495b-a8b7-35ed5e97d202
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220729/5e246786/attachment-0007.png>