[JIRA] (IDP-1793) Use Suppliers for HttpRequest/Response

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1793 ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiM2JiNDRkMzMxMjRhNGRiMThlNmQ2MTI5MWY0YjFiZmMiLCJwIjoiaiJ9 )

Re: Use Suppliers for HttpRequest/Response ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiM2JiNDRkMzMxMjRhNGRiMThlNmQ2MTI5MWY0YjFiZmMiLCJwIjoiaiJ9 )

> 
> 
> 
> I’m not convinced that we can do that without a great deal of
> cumbersomeness and fragility. Remember that the injected customObject might
> be a map (or array or any arbitrary structure) I'm pretty sure we have
> told people to inject multiple values using a map and use custom ["HttpRequest"]
> type syntax to get at the thing they want. Worse still it might be
> immutable
> 
> 

You’re right, I didn’t think of that. The Map wouldn’t break, but since the map value wouldn’t be indirected, the call breaks.

Like you were thinking, maybe we do just want new beans, and deprecate the old ones, or leave them there solely for scripts.

Maybe it’s just super late to try and fix this I guess…

( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiM2JiNDRkMzMxMjRhNGRiMThlNmQ2MTI5MWY0YjFiZmMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiM2JiNDRkMzMxMjRhNGRiMThlNmQ2MTI5MWY0YjFiZmMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100203- sha1:db6c294 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/a2d2e50f/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-14a86966-d5ce-4903-81d1-2733fe773eb8
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/a2d2e50f/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c1b7a1f7-cc14-4db3-b0c5-6c115e90ebed
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/a2d2e50f/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-93af8266-fe85-4b44-90ae-82abbef01400
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/a2d2e50f/attachment-0005.png>