[JIRA] (IDP-1793) Use Suppliers for HttpRequest/Response

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1793 ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiMjc2NzhlMzgyYmM4NGI4YWFhNzNiYjI3NTYwY2ZjM2IiLCJwIjoiaiJ9 )

Re: Use Suppliers for HttpRequest/Response ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiMjc2NzhlMzgyYmM4NGI4YWFhNzNiYjI3NTYwY2ZjM2IiLCJwIjoiaiJ9 )

I’m not sure how much our goal here is warnings to deployers, it was really more of a code hygiene issue for us. I think it’s still better if the property name fits the contract anyway though.

I think my original suggestion of dealing with scripts through detection when injecting the custom object is the right way to go, since the type isn’t known there anyway. It can just check for instanceof Supplier and invoke a cast+get operation to inject the supplied object and the scripts won’t know the difference. Meanwhile, we should be able to do what I hoped: change those 2 beans to implement only Supplier<> and not the servlet interfaces themselves.

( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiMjc2NzhlMzgyYmM4NGI4YWFhNzNiYjI3NTYwY2ZjM2IiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiMjc2NzhlMzgyYmM4NGI4YWFhNzNiYjI3NTYwY2ZjM2IiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100203- sha1:db6c294 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/a6db7d51/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-2d44734d-1818-4b86-888b-ce8ee4082154
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/a6db7d51/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-24576c35-afa6-44c2-b2c1-86351e197fe5
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/a6db7d51/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-9eb92ca6-d38d-4fac-bcd7-9dd0453f0df8
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/a6db7d51/attachment-0005.png>