[JIRA] (IDP-1984) net.shibboleth.idp.profile.audit.impl.WriteAuditLog caches the HttpServletRequest

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1984 ( https://shibboleth.atlassian.net/browse/IDP-1984?atlOrigin=eyJpIjoiMDFhY2FjNzdkMmFmNDA5MWI5NWFhNjg4ZDk4ZmRhOTIiLCJwIjoiaiJ9 )

Re: net.shibboleth.idp.profile.audit.impl.WriteAuditLog caches the HttpServletRequest ( https://shibboleth.atlassian.net/browse/IDP-1984?atlOrigin=eyJpIjoiMDFhY2FjNzdkMmFmNDA5MWI5NWFhNjg4ZDk4ZmRhOTIiLCJwIjoiaiJ9 )

It’s likely just “duh, we already store this in a member variable” duplication, but no, they can’t be in different threads. The pre/exec/post thing is just a set of hooks implemented by the actual execute method in the base classes of the actions.

( https://shibboleth.atlassian.net/browse/IDP-1984#add-comment?atlOrigin=eyJpIjoiMDFhY2FjNzdkMmFmNDA5MWI5NWFhNjg4ZDk4ZmRhOTIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1984#add-comment?atlOrigin=eyJpIjoiMDFhY2FjNzdkMmFmNDA5MWI5NWFhNjg4ZDk4ZmRhOTIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100203- sha1:db6c294 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/faa5158e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-1ad775cf-4c8c-4d2f-9841-8cd64c264c3f
Type: image/png
Size: 452 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/faa5158e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6c84fb45-5ea8-4d0b-8a18-563305edd1ef
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/faa5158e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-ee5d4ff5-470b-4e7f-819f-9565ec39c4ab
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220728/faa5158e/attachment-0005.png>