[java-idp-plugin-oidc-rp] branch main updated: Add comments for further work

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=046f68b94b5b179e2f87281f411d9d25da5710ed

The following commit(s) were added to refs/heads/main by this push:
     new 046f68b  Add comments for further work
046f68b is described below

commit 046f68b94b5b179e2f87281f411d9d25da5710ed
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Jul 22 15:04:39 2022 +0100

    Add comments for further work
---
 .../oidc/rp/impl/ProviderMetadataEncryptionParametersResolver.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProviderMetadataEncryptionParametersResolver.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProviderMetadataEncryptionParametersResolver.java
index 0e117fd..54d52e2 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProviderMetadataEncryptionParametersResolver.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProviderMetadataEncryptionParametersResolver.java
@@ -216,7 +216,8 @@ public class ProviderMetadataEncryptionParametersResolver extends BasicEncryptio
                     + " key wrapping credential");
             // Choose the first algorithm
             final JWEAlgorithm algorithm = supportedJWEKeyTransportAlgorithms.get(0);
-            // Pull out the shared secret from the config?
+            // Pull out the shared secret from the config? Perhaps pull out a shared 'OCT' secret from the
+            // config?
             //TODO check this logic
             if (criteria.contains(StaticCredentialCriterion.class)) {
                 final Credential sharedSecret = criteria.get(StaticCredentialCriterion.class).getCredential();

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.