[JIRA] (JOIDC-121) Logging messages for No allowed audiences for client warn => debug

[Simone Avogadro (Jira)]

Simone Avogadro ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A60a84ee1-4961-471b-99d8-f67c05e24403 ) *created* an issue

IdP Plugin - OIDC OP ( https://shibboleth.atlassian.net/browse/JOIDC?atlOrigin=eyJpIjoiNjc1YTMwOWFlMWYzNDM3MmE3YmZjNzllZjUxMzk0NjAiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/JOIDC-121?atlOrigin=eyJpIjoiNjc1YTMwOWFlMWYzNDM3MmE3YmZjNzllZjUxMzk0NjAiLCJwIjoiaiJ9 ) JOIDC-121 ( https://shibboleth.atlassian.net/browse/JOIDC-121?atlOrigin=eyJpIjoiNjc1YTMwOWFlMWYzNDM3MmE3YmZjNzllZjUxMzk0NjAiLCJwIjoiaiJ9 ) Logging messages for No allowed audiences for client warn => debug ( https://shibboleth.atlassian.net/browse/JOIDC-121?atlOrigin=eyJpIjoiNjc1YTMwOWFlMWYzNDM3MmE3YmZjNzllZjUxMzk0NjAiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) Components: Logging and Metrics Created: 21/Jul/22 11:04 AM Priority: Trivial Reporter: Simone Avogadro ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A60a84ee1-4961-471b-99d8-f67c05e24403 )

Class net.shibboleth.idp.plugin.oidc.op.oauth2.profile.impl.ValidateAudience:190 logs warning in a condition where ti should probably log at debug level

if (allowNone) {
	if (previouslyGrantedAudience != null || requestedAudience != null) {
		log.warn("{} No allowed audiences for client {}, OP will be sole audience", getLogPrefix(),
				clientId);
	} else {
		log.debug("{} No allowed audiences for client {}, OP will be sole audience", getLogPrefix(),
				clientId);
	}
}

when  {{ previouslyGrantedAudience  }}  is an empty Collection this logs a warning, instead it should probably log at debug level.

( https://shibboleth.atlassian.net/browse/JOIDC-121#add-comment?atlOrigin=eyJpIjoiNjc1YTMwOWFlMWYzNDM3MmE3YmZjNzllZjUxMzk0NjAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-121#add-comment?atlOrigin=eyJpIjoiNjc1YTMwOWFlMWYzNDM3MmE3YmZjNzllZjUxMzk0NjAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:c075b5d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/b972b43c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-964b2803-3cfa-4e9e-adfd-79d435471516
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/b972b43c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-86569807-800c-4c6d-9fd9-67b47328fce4
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/b972b43c/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-2d869112-7618-4f73-8c93-b100665664a1
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/b972b43c/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-311b26ea-8462-40c5-bbeb-9ba22448ebd0
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/b972b43c/attachment-0007.png>