[java-shib-attribute] 01/03: IDP-1959 IdPAttributes to stop carrying Display Information

Rod Widdowson rdw at steadingsoftware.com
Sun Jul 17 14:13:56 UTC 2022


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commit;h=99766eb8f1b36c47a1cd5c1806b7a7fcce1a2bce

commit 99766eb8f1b36c47a1cd5c1806b7a7fcce1a2bce
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sun Jul 17 11:54:48 2022 +0100

    IDP-1959 IdPAttributes to stop carrying Display Information
    
    https://shibboleth.atlassian.net/browse/IDP-1959
    
    AttributeResolverServiceStrategy stops passing
    SupressDisplayinformation down to the resolvers
---
 .../impl/AttributeResolverServiceStrategy.java     | 23 ----------------------
 1 file changed, 23 deletions(-)

diff --git a/shib-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/AttributeResolverServiceStrategy.java b/shib-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/AttributeResolverServiceStrategy.java
index 8e6b595f1..9e18ae538 100644
--- a/shib-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/AttributeResolverServiceStrategy.java
+++ b/shib-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/impl/AttributeResolverServiceStrategy.java
@@ -50,9 +50,6 @@ public class AttributeResolverServiceStrategy extends AbstractIdentifiableInitia
     /** Whether to strip null attribute values. */
     private boolean stripNulls;
 
-    /** Whether to attach DisplayInfo to attributes. */
-    private boolean suppressDisplayInformation;
-    
     /** Do we strip nulls from attribute values.
     * @return Returns whether to strip nulls from attribute values
     */
@@ -68,26 +65,7 @@ public class AttributeResolverServiceStrategy extends AbstractIdentifiableInitia
        stripNulls = doStripNulls;
     }
 
-    /** Do we allow addition of Display Information?
-     * @return whether we are suppressing
-     */
-    public boolean isSuppressDisplayInformation() {
-       return suppressDisplayInformation;
-    }
-
-    /**
-     * Set whether we suppress addition of Display Information.
-     * @deprecated Display Information should be consulted at point of use
-     *
-     * @param what true if we suppress the addition.
-     */
-    @Deprecated(forRemoval = true, since = "4.2")
-    public void setSuppressDisplayInformation(final boolean what) {
-        suppressDisplayInformation = what;
-    }
-
     /** {@inheritDoc} */
-    @SuppressWarnings("removal")
     @Nullable public ServiceableComponent<AttributeResolver> apply(@Nullable final ApplicationContext appContext) {
 
         final Collection<AttributeDefinition> definitions =
@@ -103,7 +81,6 @@ public class AttributeResolverServiceStrategy extends AbstractIdentifiableInitia
         resolver.setDataConnectors(connectors);
         resolver.setId(getId());
         resolver.setStripNulls(isStripNulls());
-        resolver.setSuppressDisplayInformation(isSuppressDisplayInformation());
         resolver.setApplicationContext(appContext);
 
         try {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list