[JIRA] (JSPT-118) Make Component Initialization & destruction non-idempotent

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSPT-118 ( https://shibboleth.atlassian.net/browse/JSPT-118?atlOrigin=eyJpIjoiMjMyZTM2YjRkMjQwNGY4MWI3YThlMWZiNTcwMWIzNmUiLCJwIjoiaiJ9 )

Re: Make Component Initialization & destruction non-idempotent ( https://shibboleth.atlassian.net/browse/JSPT-118?atlOrigin=eyJpIjoiMjMyZTM2YjRkMjQwNGY4MWI3YThlMWZiNTcwMWIzNmUiLCJwIjoiaiJ9 )

I dove into this a bit further and came upon this interesting comment (of mine) in net.shibboleth.ext.spring.service.AbstractServiceableComponent line1165 ff

       // If we were not created by spring we need to do the destroy of ourself.
       // Note that we will end up being called here but will fall out at the top.
       destroy();

I am not yet sure whether this matters or not. All services are created by Spring and it seems reasonable to assume that most other beans are as well. But are we confident that this is and will always be the case? On the other hand, what is the impact of getting this wrong? In the Service case we will leak threads and in other cases we might leak open file references.

This was destroy. I’ll look at initialize ‘some time’

( https://shibboleth.atlassian.net/browse/JSPT-118#add-comment?atlOrigin=eyJpIjoiMjMyZTM2YjRkMjQwNGY4MWI3YThlMWZiNTcwMWIzNmUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-118#add-comment?atlOrigin=eyJpIjoiMjMyZTM2YjRkMjQwNGY4MWI3YThlMWZiNTcwMWIzNmUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:365db85 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220716/697cfe3e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-74975206-028a-48cb-a119-76add24e92ca
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220716/697cfe3e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-d2c780f8-635c-464f-bf86-6afe12529548
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220716/697cfe3e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6411946a-d45f-4cc1-b772-dfa7999bf312
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220716/697cfe3e/attachment-0005.png>