[JIRA] (JSPT-98) Integrate lifecycle checking methods in base classes

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on JSPT-98 ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiY2RkMmRlODhlZDEzNDFhY2E5ZmVhMjczYmQzYjMzZjciLCJwIjoiaiJ9 )

Re: Integrate lifecycle checking methods in base classes ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiY2RkMmRlODhlZDEzNDFhY2E5ZmVhMjczYmQzYjMzZjciLCJwIjoiaiJ9 )

As I mentioned in another ticket, I’m kind of withdrawing this comment:

“My vote would be towards not permitting either multiple inits or multiple destroys.“

I’m primarily concerned that the doInitialize and doDestroy chains don’t need to understand multiple invocation. I am pretty sure there is code which will fail or malfunction if those are called multiple times.

The good news is that the existing implementation protects against that, and does so moreover in a way that looks to me as if it’s thread-safe. There may be some wild edge case where that’s not the case but I haven’t been able to come up with it yet.

Anyway, TL;DR: the current implementation of AbstractInitializableComponent seems right to me.

( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiY2RkMmRlODhlZDEzNDFhY2E5ZmVhMjczYmQzYjMzZjciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiY2RkMmRlODhlZDEzNDFhY2E5ZmVhMjczYmQzYjMzZjciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:e905ae5 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220714/81bf447a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5e7076c2-cd87-44cc-ae2d-e55f5e7217c0
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220714/81bf447a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-d099ff4e-5035-4e79-afa0-c4478ebd5497
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220714/81bf447a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-b86a16ae-22fa-47a3-a001-9fa7ab479c1e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220714/81bf447a/attachment-0005.png>