[JIRA] (JSPT-98) Integrate lifecycle checking methods in base classes

Wed Jul 13 15:31:37 UTC 2022

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSPT-98 ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiNzM1NmQ3NTZiOTAyNDc0NGI4MDM2MTA2ZTkwOGFkNWMiLCJwIjoiaiJ9 )

Re: Integrate lifecycle checking methods in base classes ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiNzM1NmQ3NTZiOTAyNDc0NGI4MDM2MTA2ZTkwOGFkNWMiLCJwIjoiaiJ9 )

* Java-support

* AbstractInitializableComponentTest (test to allow double init)
* BasicParserPoolTest (ditto)

* OpenSAML

* Clean

* Spring-extensions

* ReloadableSpringServiceTest.deferedReload:174
* ReloadableSpringServiceTest.reloadableService:112
* ReloadableSpringServiceTest.testNotFailFast:235
* Under investigation. Almost certainly because we destroy the components and Spring does so as well as part of Context cleanup

* Shib-metadata-spring-impl

* InlineMetadataParserTest.multiple:111
* UI

* shib-attribute-impl

* JDBCPairwiseIdStoreTest.initializeAndGetters:95

* shib-attribute-resolver-impl

* ComputedIDDataConnectorTest.altDataConnector:181->constructResolver:131->constructResolver:149
* ComputedIDDataConnectorTest.dataConnector:115
* StoredIDDataConnectorTest.noSalt:123
* LDAPDataConnectorTest.escape:280
* LDAPDataConnectorTest.resolveWithDepends:242
* LDAPDataConnectorTest.resolveWithMultiValueDepends:259
* AttributeResolverImplTest.resolveDataConnectorFailDefault:560->resolveDataConnectorFail:537
* AttributeResolverImplTest.resolveDataConnectorFailPropagate:568->resolveDataConnectorFail:537
* AttributeResolverImplTest.resolveDataConnectorFailPropagateRetry:572->resolveDataConnectorFail:537
* AttributeResolverImplTest.resolveDataConnectorFailRetry:564->resolveDataConnectorFail:537
AttributeResolverImplTest.resolveWithDependencyFail1:441

* shib-attribute-resolver-spring

* AttributeResolverTest.mappedTemplate:325
* AttributeResolverTest.preResolve:392
* AttributeResolverTest.service:157->helper:208
* AttributeResolverTest.serviceNullStrip:161->helper:208
* IdP1676Test.failFast:160->getResolver:137
* IdP1676Test.failFastNoPE:177->getResolver:137
* IdP1676Test.normal:190->getResolver:137
* IdP1676Test.normalNoPE:212->getResolver:137
* ScriptedAttributeParserTest.dupl:64->BaseAttributeDefinitionParserTest.getAttributeDefn:174->BaseAttributeDefinitionParserTest.getAttributeDefn:131->BaseAttributeDefinitionParserTest.getBean:110
* ScriptedAttributeParserTest. file:52- >BaseAttributeDefinitionParserTest.getAttributeDefn:163->BaseAttributeDefinitionParserTest.getAttributeDefn:174->BaseAttributeDefinitionParserTest.getAttributeDefn:131->BaseAttributeDefinitionParserTest.getBean:110
* ScriptedAttributeParserTest.inline:43->BaseAttributeDefinitionParserTest.getAttributeDefn:163->BaseAttributeDefinitionParserTest.getAttributeDefn:174->BaseAttributeDefinitionParserTest.getAttributeDefn:131->BaseAttributeDefinitionParserTest.getBean:110
SimpleAttributeParserTest.populated2:91
* SimpleAttributeParserTest.simplePopulated:68
* ScriptDataConnectorParserTest.both:95->BaseAttributeDefinitionParserTest.getDataConnector:178->BaseAttributeDefinitionParserTest.getDataConnector:189->BaseAttributeDefinitionParserTest.getBean:110
* ScriptDataConnectorParserTest.resolver:47->testConnector:52->BaseAttributeDefinitionParserTest.getDataConnector:178->BaseAttributeDefinitionParserTest.getDataConnector:189->BaseAttributeDefinitionParserTest.getBean:110
* ScriptDataConnectorParserTest.tooManyFiles:85->BaseAttributeDefinitionParserTest.getDataConnector:178->BaseAttributeDefinitionParserTest.getDataConnector:189->BaseAttributeDefinitionParserTest.getBean:110
* ScriptDataConnectorParserTest.tooManyScript:90->BaseAttributeDefinitionParserTest.getDataConnector:178->BaseAttributeDefinitionParserTest.getDataConnector:189->BaseAttributeDefinitionParserTest.getBean:110
* StoredIdDataConnectorParserTest.beanManaged:103->testIt:60
* StoredIdDataConnectorParserTest.withOutSalt:112->testIt:60
* StoredIdDataConnectorParserTest.withSalt:71->testIt:60
* LDAPDataConnectorParserTest.hybridConfig:545
* LDAPDataConnectorParserTest.springConfig:478
* LDAPDataConnectorParserTest.springPropsConfig:494
* LDAPDataConnectorParserTest.v2Config:188
* LDAPDataConnectorParserTest.v2MinimalConfig:273
* LDAPDataConnectorParserTest.v2MinimalPoolConfig:345
* LDAPDataConnectorParserTest.v2NoSec:209
* LDAPDataConnectorParserTest.v2PropsConfig:362

* shib-attribute-filter-spring

* 76 failures - all in much the same place

* idp-saml-profile-api

* EntityAttributesPredicateTest.testMultiLevelMappedMatch:174
* EntityAttributesPredicateTest.testSimpleMatchMapped:160

* idp-conf

* ResolverTestFlowTest>AbstractTestNGSpringContextTests.run:184->testJSONResolverTestFlow:58
ResolverTestFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML1ResolverTestFlow:77
* ResolverTestFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML2ResolverTestFlow:97
* SamlValidateFlowTest>AbstractTestNGSpringContextTests.run:184->testSuccess:100
* SamlValidateFlowTest>AbstractTestNGSpringContextTests.run:184->testSuccessWhenResolveAttributesFalse:180
* SamlValidateFlowTest>AbstractTestNGSpringContextTests.run:184->testSuccessWithConsent:132
* ServiceValidateFlowTest>AbstractTestNGSpringContextTests.run:184->testSuccess:127
* ServiceValidateFlowTest>AbstractTestNGSpringContextTests.run:184->testSuccessWithConsent:165
* SAML1AttributeQueryFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML1AttributeQueryFlow:93->AbstractSAML1FlowTest.validateResult:56
* SAML1AttributeQueryFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML1AttributeQueryFlowWithDesignators:115->AbstractSAML1FlowTest.validateResult:56
* SAML1UnsolicitedSSOFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML1UnsolicitedSSOFlow:50->AbstractSAML1FlowTest.validateResult:43->AbstractSAML1FlowTest.validateResult:56
* SAML2AttributeQueryFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML2AttributeQueryFlow:98->AbstractSAML2FlowTest.validateResult:58
* SAML2AttributeQueryFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML2AttributeQueryFlowWithDesignators:120->AbstractSAML2FlowTest.validateResult:58
* SAML2ECPSSOFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML2ECPFlow:58->AbstractSAML2FlowTest.validateResult:45->AbstractSAML2FlowTest.validateResult:58
* SAML2POSTSSOFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML2POSTSSOFlow:60->AbstractSAML2FlowTest.validateResult:45->AbstractSAML2FlowTest.validateResult:58
* SAML2POSTSimpleSignSSOFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML2POSTSSOFlow:60->AbstractSAML2FlowTest.validateResult:45->AbstractSAML2FlowTest.validateResult:58
* SAML2RedirectSSOFlowTest>AbstractTestNGSpringContextTests.run:184->testSAML2RedirectFlow:63->AbstractSAML2FlowTest.validateResult:45->AbstractSAML2FlowTest.validateResult:58
* SAML2FlowTest.validateResult:45->AbstractSAML2FlowTest.validateResult:58

I haven’t looked at the testbed yet (I don’t have it running under the new repository regime yet)

( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiNzM1NmQ3NTZiOTAyNDc0NGI4MDM2MTA2ZTkwOGFkNWMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiNzM1NmQ3NTZiOTAyNDc0NGI4MDM2MTA2ZTkwOGFkNWMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:0f3e007 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/d4e90d0a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-905e13c8-19d8-4f33-9aff-d712b7318233
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/d4e90d0a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-d92a93ce-5a85-41b5-89d7-b3eac4df1117
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/d4e90d0a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a42a82fa-5efd-41ee-8ac0-87edc2f94b0b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/d4e90d0a/attachment-0005.png>