[JIRA] (JSPT-98) Integrate lifecycle checking methods in base classes

Rod Widdowson (Jira) jira at shibboleth.atlassian.net
Wed Jul 13 14:31:05 UTC 2022


Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSPT-98 ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiMGJjMGQxZWQzMjExNDRiMGExZmE1NmNiYmFiYTI1N2IiLCJwIjoiaiJ9 )

Re: Integrate lifecycle checking methods in base classes ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiMGJjMGQxZWQzMjExNDRiMGExZmE1NmNiYmFiYTI1N2IiLCJwIjoiaiJ9 )

I hated the names to start with, but grew to like them. I know that Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) (who created the methods to start with isn’t in love with them).

I am completely open to a mass-refactor but I absolutely don’t get involved in “what to call it” discussions, so I’ll leave this open for 48 hours to allow other to pitch in.

( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiMGJjMGQxZWQzMjExNDRiMGExZmE1NmNiYmFiYTI1N2IiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiMGJjMGQxZWQzMjExNDRiMGExZmE1NmNiYmFiYTI1N2IiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:0f3e007 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/66c2cfe3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-74ec8a63-76cd-45ae-9d7c-8dedd2db3257
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/66c2cfe3/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-062b49d8-4724-44f3-8102-80151511d4b9
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/66c2cfe3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-59baf127-3fea-4c1e-8895-5a5e389c1446
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/66c2cfe3/attachment-0005.png>


More information about the commits mailing list