[JIRA] (JDUO-60) idp.authn.DuoOIDC.addDefaultPrincipals property should be supported

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

IdP Plugin - Duo ( https://shibboleth.atlassian.net/browse/JDUO?atlOrigin=eyJpIjoiZGFjNjU0ZmRkODRlNGFjODhjOWNlMzA5NzgyODA4MjQiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JDUO-60?atlOrigin=eyJpIjoiZGFjNjU0ZmRkODRlNGFjODhjOWNlMzA5NzgyODA4MjQiLCJwIjoiaiJ9 ) JDUO-60 ( https://shibboleth.atlassian.net/browse/JDUO-60?atlOrigin=eyJpIjoiZGFjNjU0ZmRkODRlNGFjODhjOWNlMzA5NzgyODA4MjQiLCJwIjoiaiJ9 ) idp.authn.DuoOIDC.addDefaultPrincipals property should be supported ( https://shibboleth.atlassian.net/browse/JDUO-60?atlOrigin=eyJpIjoiZGFjNjU0ZmRkODRlNGFjODhjOWNlMzA5NzgyODA4MjQiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 1.0.0, 1.1.0, 1.1.1, 1.2.0 Assignee: Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) Components: duo-impl Created: 12/Jul/22 9:06 AM Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

I think for consistency we should have a property that can override the default behavior populating the Subject even if there’s no mapping funtion set. The current bean does this:

p:addDefaultPrincipals="#{getObject('shibboleth.authn.DuoOIDC.ContextToPrincipalMappingStrategy') == null}"/>

If possible, I think it should be altered so that if idp.authn.DuoOIDC.addDefaultPrincipals is set (defaulting true), and the strategy is null, that takes over.

So something like:

p:addDefaultPrincipals="#{%{idp.authn.DuoOIDC.addDefaultPrincipals:true} && getObject('shibboleth.authn.DuoOIDC.ContextToPrincipalMappingStrategy') == null}"/>

?

I think that works. That way if the strategy isn’t set and the property is true, you get the current behavior but if the property is false, you don’t get it, even if the strategy isn’t set. Since it defaults to true, I think it’s a compatible change.

( https://shibboleth.atlassian.net/browse/JDUO-60#add-comment?atlOrigin=eyJpIjoiZGFjNjU0ZmRkODRlNGFjODhjOWNlMzA5NzgyODA4MjQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JDUO-60#add-comment?atlOrigin=eyJpIjoiZGFjNjU0ZmRkODRlNGFjODhjOWNlMzA5NzgyODA4MjQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:7f0496f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220712/914062ea/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e3bc95fb-63fd-43fc-862a-77ca30e8e0b0
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220712/914062ea/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-3c581547-bf84-41f5-b15f-537a0267b201
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220712/914062ea/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-55f1048d-49e4-4d0d-99de-c6ab9adb0954
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220712/914062ea/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a2d0d2a1-4008-4425-b17b-3659a6b8294c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220712/914062ea/attachment-0007.png>