[JIRA] (JSPT-85) Reconsider direct use of SHA1PRNG in identifier generators

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *reopened* an issue

I'm reopening this (sigh) because at least one noteworthy Java security contributor in another context noted that there are I guess better options than SHA1PRNG at this point.

His suggestions were to just default it via new SecureRandom() or possibly use the Java 8+ getInstanceStrong method, which is apparently more focused on use cases for long-lived secrets (keys).

Not sure, but I guess this isn't the ideal behavior.

With V5 coming, it's probably time to dump this whole separate class structure for the identifier generators and use one.

Java Support ( https://shibboleth.atlassian.net/browse/JSPT?atlOrigin=eyJpIjoiNzZlZDg0ZWY1NTFjNDM3MGI3MThjNDIxNTQ5ZjU5MWEiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/JSPT-85?atlOrigin=eyJpIjoiNzZlZDg0ZWY1NTFjNDM3MGI3MThjNDIxNTQ5ZjU5MWEiLCJwIjoiaiJ9 ) JSPT-85 ( https://shibboleth.atlassian.net/browse/JSPT-85?atlOrigin=eyJpIjoiNzZlZDg0ZWY1NTFjNDM3MGI3MThjNDIxNTQ5ZjU5MWEiLCJwIjoiaiJ9 ) Reconsider direct use of SHA1PRNG in identifier generators ( https://shibboleth.atlassian.net/browse/JSPT-85?atlOrigin=eyJpIjoiNzZlZDg0ZWY1NTFjNDM3MGI3MThjNDIxNTQ5ZjU5MWEiLCJwIjoiaiJ9 )

Change By: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Assignee: Unassigned Scott Cantor Resolution: Invalid Status: Closed Reopened

( https://shibboleth.atlassian.net/browse/JSPT-85#add-comment?atlOrigin=eyJpIjoiNzZlZDg0ZWY1NTFjNDM3MGI3MThjNDIxNTQ5ZjU5MWEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-85#add-comment?atlOrigin=eyJpIjoiNzZlZDg0ZWY1NTFjNDM3MGI3MThjNDIxNTQ5ZjU5MWEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:0577670 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220706/c478b3a5/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-bdfe4685-65b7-4375-af5f-f26093b5c388
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220706/c478b3a5/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-a02ae005-6e87-41c4-8d02-128c579353ad
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220706/c478b3a5/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-d2f10755-7423-47f4-a100-e20815e3d286
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220706/c478b3a5/attachment-0005.png>