[JIRA] (IDP-1970) SAML Proxy: EventContext retrieved from the wrong profile context after message encoding

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMmFjOTFlMmVhOTY0NGUyODk2NzQzNTcyOGUyZDI0ZDciLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-1970?atlOrigin=eyJpIjoiMmFjOTFlMmVhOTY0NGUyODk2NzQzNTcyOGUyZDI0ZDciLCJwIjoiaiJ9 ) IDP-1970 ( https://shibboleth.atlassian.net/browse/IDP-1970?atlOrigin=eyJpIjoiMmFjOTFlMmVhOTY0NGUyODk2NzQzNTcyOGUyZDI0ZDciLCJwIjoiaiJ9 ) SAML Proxy: EventContext retrieved from the wrong profile context after message encoding ( https://shibboleth.atlassian.net/browse/IDP-1970?atlOrigin=eyJpIjoiMmFjOTFlMmVhOTY0NGUyODk2NzQzNTcyOGUyZDI0ZDciLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.0.0, 4.0.1, 4.1.0, 4.1.1, 4.1.2, 4.1.3, 4.1.4, 4.1.5, 4.1.6, 4.1.7, 4.2.0, 4.2.1 Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Authentication Created: 05/Jul/22 10:02 AM Priority: Trivial Reporter: Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 )

I *think* the SAMLAuthnController is looking for the EventContext after message encoding in the (wrong) root profile request context, whereas it will actually be added as a subcontext of the nested profile request context (lines 199 and 200). For example:

samlContext.getEncodeMessageAction().execute(nestedPRC);
final EventContext eventCtx = prc.getSubcontext(EventContext.class);

I think should be:

samlContext.getEncodeMessageAction().execute(nestedPRC);
final EventContext eventCtx = nestedPRC.getSubcontext(EventContext.class);

If so, I’m happy to change it over.

( https://shibboleth.atlassian.net/browse/IDP-1970#add-comment?atlOrigin=eyJpIjoiMmFjOTFlMmVhOTY0NGUyODk2NzQzNTcyOGUyZDI0ZDciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1970#add-comment?atlOrigin=eyJpIjoiMmFjOTFlMmVhOTY0NGUyODk2NzQzNTcyOGUyZDI0ZDciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:2506565 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220705/bdc8344a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-7867d65a-6f50-49c4-85cf-85ce63a357a8
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220705/bdc8344a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-29992fa5-e242-4800-be3c-537929242090
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220705/bdc8344a/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-ec7333ce-f050-47dd-aa9d-91b310c9051e
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220705/bdc8344a/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-f4ea468b-2a75-4dde-93e4-29bffd91eba9
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220705/bdc8344a/attachment-0007.png>