[JIRA] (OSJ-348) SAML Assertion signature validation should evaluate algorithm policy

[Brent Putman (Jira)]

Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) *created* an issue

OpenSAML - Java ( https://shibboleth.atlassian.net/browse/OSJ?atlOrigin=eyJpIjoiYzdjOGE5M2FiNzJkNGRmMWFhMzBlZGYyOWEyMjE4YmEiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/OSJ-348?atlOrigin=eyJpIjoiYzdjOGE5M2FiNzJkNGRmMWFhMzBlZGYyOWEyMjE4YmEiLCJwIjoiaiJ9 ) OSJ-348 ( https://shibboleth.atlassian.net/browse/OSJ-348?atlOrigin=eyJpIjoiYzdjOGE5M2FiNzJkNGRmMWFhMzBlZGYyOWEyMjE4YmEiLCJwIjoiaiJ9 ) SAML Assertion signature validation should evaluate algorithm policy ( https://shibboleth.atlassian.net/browse/OSJ-348?atlOrigin=eyJpIjoiYzdjOGE5M2FiNzJkNGRmMWFhMzBlZGYyOWEyMjE4YmEiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.0.0, 4.0.1, 4.1.0, 4.1.1 Assignee: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) Components: SAML 2 Profiles, Security Created: 26/Jan/22 10:14 PM Fix Versions: 4.1.2, 4.2.0 Priority: Major Reporter: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e )

SAML Assertion validation components are not validating any configured algorithm policy (include and exclude lists).

It’s all in how the org.opensaml.saml.common.assertion.ValidationContext gets built.

The original code was for delegation/WS-Security:

org.opensaml.saml.saml2.wssecurity.messaging.impl.DefaultSAML20AssertionValidationContextBuilder

The newer SAML 2 profile code for proxy and eventual Java SP was modeled on that:

org.opensaml.saml.saml2.profile.impl.DefaultAssertionValidationContextBuilder

The relevant methods in both which build the signature CriteriaSet should be updated to insert a SignatureValidationParametersCriterion based on context data, if present.

( https://shibboleth.atlassian.net/browse/OSJ-348#add-comment?atlOrigin=eyJpIjoiYzdjOGE5M2FiNzJkNGRmMWFhMzBlZGYyOWEyMjE4YmEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-348#add-comment?atlOrigin=eyJpIjoiYzdjOGE5M2FiNzJkNGRmMWFhMzBlZGYyOWEyMjE4YmEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100189- sha1:0bbbf41 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220127/b12e1126/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4196fdf2-343f-4104-804a-818332dddc4e
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220127/b12e1126/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-major-ef0b36d9-8c93-4891-9256-df0edae60f2b
Type: image/png
Size: 696 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220127/b12e1126/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7f34d6b8-f436-4c6c-a2a2-09dcde2f74a7
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220127/b12e1126/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-96a37104-9b73-4736-afd2-6c121e0fa565
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220127/b12e1126/attachment-0007.png>