[JIRA] (JOIDC-70) Narrowing scopes by request parameters not supported

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JOIDC-70 ( https://shibboleth.atlassian.net/browse/JOIDC-70?atlOrigin=eyJpIjoiYjUzNGIyZDc3M2Q3NDdlMDk3NjBlOTRhYTUzZDE4NTMiLCJwIjoiaiJ9 )

Re: Narrowing scopes by request parameters not supported ( https://shibboleth.atlassian.net/browse/JOIDC-70?atlOrigin=eyJpIjoiYjUzNGIyZDc3M2Q3NDdlMDk3NjBlOTRhYTUzZDE4NTMiLCJwIjoiaiJ9 )

I believe the full fix is to combine the two scope-handling/validating actions into one step that combines both, and move the combined ValidateScope action down to where the ReduceValidatedScope action step appears in the token flow.

None of the intervening steps requires validated scopes be known, and I don’t even see any optimizing going on in the case where none of the scopes are registered in metadata, the original code wasn’t failing on that case, it just continued processing with no scopes set.

Moving it down to the Reduce spot allows it to detect that encoded claims exist and dispose of them when the requested set filters down the effective scopes.

( https://shibboleth.atlassian.net/browse/JOIDC-70#add-comment?atlOrigin=eyJpIjoiYjUzNGIyZDc3M2Q3NDdlMDk3NjBlOTRhYTUzZDE4NTMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-70#add-comment?atlOrigin=eyJpIjoiYjUzNGIyZDc3M2Q3NDdlMDk3NjBlOTRhYTUzZDE4NTMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100187- sha1:319aa7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220105/a409dfbe/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5733a1be-6d03-4d2b-b0b7-78202f259a37
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220105/a409dfbe/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-723541ce-3aef-45a5-97c1-4b3dfa7f55b5
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220105/a409dfbe/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-9ca6ce4b-66a4-4c0c-a91b-e679c81f760f
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220105/a409dfbe/attachment-0005.png>