[JIRA] (JOIDC-70) Narrowing scopes by request parameters not supported

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JOIDC-70 ( https://shibboleth.atlassian.net/browse/JOIDC-70?atlOrigin=eyJpIjoiZjk4Y2ZhNmY0NDdhNDg4ZTljNjkxYjUzZWI3MjdjYzciLCJwIjoiaiJ9 )

Re: Narrowing scopes by request parameters not supported ( https://shibboleth.atlassian.net/browse/JOIDC-70?atlOrigin=eyJpIjoiZjk4Y2ZhNmY0NDdhNDg4ZTljNjkxYjUzZWI3MjdjYzciLCJwIjoiaiJ9 )

I committed an initial attempt at a fix in 1764b5645bc3585650037203c99b55e8f1c1eb22

Included in larger changes to start adding client_credentials grant support, but hopefully addressing this as well.

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) I’ll leave this assigned to you for review in the existing flows and feature set.

A concern I had is whether the unit tests for e.g. the token endpoint are strictly correct in that I think they end up (and did before) with empty scopes in the tokens issued. The only difference is that the field is actually null in the context rather than just an empty Scope object. It was the two secret JWT tests that seemed to fail because of that. Not sure why those specifically, maybe the other tests ended up populating the scope somehow.

( https://shibboleth.atlassian.net/browse/JOIDC-70#add-comment?atlOrigin=eyJpIjoiZjk4Y2ZhNmY0NDdhNDg4ZTljNjkxYjUzZWI3MjdjYzciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-70#add-comment?atlOrigin=eyJpIjoiZjk4Y2ZhNmY0NDdhNDg4ZTljNjkxYjUzZWI3MjdjYzciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100187- sha1:319aa7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220104/c24c439a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-3b0815e0-72b6-417f-a123-9c5977f2e8c8
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220104/c24c439a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-ad899819-7efc-46c4-b0ea-694eec9cdd17
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220104/c24c439a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-b96e1fd1-9f6c-4571-92dd-0b5b745551f1
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220104/c24c439a/attachment-0005.png>