[JIRA] (JCOMOIDC-40) Complete OIDCAttributeTranscoder decode values function
Philip Smart (Jira)
jira at shibboleth.atlassian.net
Fri Feb 25 14:45:08 UTC 2022
Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-40 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40?atlOrigin=eyJpIjoiYzc3M2ViODU4ZmM0NDk4NzkzNGQ2MTJkNzZmYzY4ZGUiLCJwIjoiaiJ9 )
Re: Complete OIDCAttributeTranscoder decode values function ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40?atlOrigin=eyJpIjoiYzc3M2ViODU4ZmM0NDk4NzkzNGQ2MTJkNzZmYzY4ZGUiLCJwIjoiaiJ9 )
I committed the current changes and decoding logic in d4155614eab8baa256c7c860d837d52c833f0692. It no longer throws an exception on an unexpected type, just returns an empty list. I added a test for the ClaimsSetRequest.Entry type and it seems to work. Not sure how nice this looks, but can revisit if needed.
An issue in production might be; it is logging (trace) the fact it can not convert values because they are the wrong type, which may get confusing if this is legitimately not going to decode the values of the ClaimsSetRequest.Entry type.
( https://shibboleth.atlassian.net/browse/JCOMOIDC-40#add-comment?atlOrigin=eyJpIjoiYzc3M2ViODU4ZmM0NDk4NzkzNGQ2MTJkNzZmYzY4ZGUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40#add-comment?atlOrigin=eyJpIjoiYzc3M2ViODU4ZmM0NDk4NzkzNGQ2MTJkNzZmYzY4ZGUiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100192- sha1:2947bec )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/e08ecb1f/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-a99eb9a5-b70e-4bc9-a448-d93a6aaf8204
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/e08ecb1f/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-f0bc0a2c-a7fa-4701-bf5e-10113ced27c8
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/e08ecb1f/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-10a82e98-9182-43f3-9748-3632a341d342
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/e08ecb1f/attachment-0005.png>
More information about the commits
mailing list