[JIRA] (IDP-1908) IdP mishandles "empty" RequestedPrincipalContext

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiY2NlMDZiM2E4NzdhNDRmMDg4ZmI4YWE2NmU0NWUwYmQiLCJwIjoiaiJ9 ) / New Feature ( https://shibboleth.atlassian.net/browse/IDP-1908?atlOrigin=eyJpIjoiY2NlMDZiM2E4NzdhNDRmMDg4ZmI4YWE2NmU0NWUwYmQiLCJwIjoiaiJ9 ) IDP-1908 ( https://shibboleth.atlassian.net/browse/IDP-1908?atlOrigin=eyJpIjoiY2NlMDZiM2E4NzdhNDRmMDg4ZmI4YWE2NmU0NWUwYmQiLCJwIjoiaiJ9 ) IdP mishandles "empty" RequestedPrincipalContext ( https://shibboleth.atlassian.net/browse/IDP-1908?atlOrigin=eyJpIjoiY2NlMDZiM2E4NzdhNDRmMDg4ZmI4YWE2NmU0NWUwYmQiLCJwIjoiaiJ9 )

Issue Type: New Feature Affects Versions: 4.1.0, 4.1.1, 4.1.2, 4.1.3, 4.1.4, 4.1.5 Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Authentication Created: 25/Feb/22 9:19 AM Fix Versions: 4.2.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

The annotation for getOperator() says non-null but it’s actually nullable, and the code doesn’t really guard against that case. Since the context starts out “empty”, that should be checked anywhere we use the context.

( https://shibboleth.atlassian.net/browse/IDP-1908#add-comment?atlOrigin=eyJpIjoiY2NlMDZiM2E4NzdhNDRmMDg4ZmI4YWE2NmU0NWUwYmQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1908#add-comment?atlOrigin=eyJpIjoiY2NlMDZiM2E4NzdhNDRmMDg4ZmI4YWE2NmU0NWUwYmQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100192- sha1:2947bec )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/8b17cd34/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-2b0df01b-ba8e-48e7-b256-e3a3d5bdc68d
Type: image/png
Size: 341 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/8b17cd34/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-3c28a608-b77e-458b-88f1-b3abf983c3a4
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/8b17cd34/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-6802441e-7b6f-4e01-93c3-a7bd7e6d772d
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/8b17cd34/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-0e5efea7-3634-4e9f-a111-e5d76183e898
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220225/8b17cd34/attachment-0007.png>