[java-identity-provider] branch main updated: Javadoc nits.
Scott Cantor
cantor.2 at osu.edu
Thu Feb 17 13:17:08 UTC 2022
This is an automated email from the git hooks/post-receive script.
scantor pushed a commit to branch main
in repository java-identity-provider.
View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=f7788141ddcec0e8a42ff334ec3a85a97c25f9d5
The following commit(s) were added to refs/heads/main by this push:
new f7788141d Javadoc nits.
f7788141d is described below
commit f7788141ddcec0e8a42ff334ec3a85a97c25f9d5
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Feb 17 08:17:04 2022 -0500
Javadoc nits.
---
.../spring/policy/ProfileRuleParserTest.java | 2 +-
.../saml/IssuerNameIDFormatRuleParserTest.java | 2 +-
...equesterEntityAttributeExactRuleParserTest.java | 2 +-
...equesterEntityAttributeRegexRuleParserTest.java | 2 +-
...roxiedRequesterInEntityGroupRuleParserTest.java | 23 +++++++++++++++++-----
...equesterEntityAttributeExactRuleParserTest.java | 2 +-
...equesterEntityAttributeRegexRuleParserTest.java | 2 +-
.../saml/RequesterNameIDFormatRuleParserTest.java | 2 +-
.../impl/SelectProfileConfigurationTest.java | 2 +-
.../saml2/profile/impl/AddAuthnRequestTest.java | 2 +-
10 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/policy/ProfileRuleParserTest.java b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/policy/ProfileRuleParserTest.java
index 79beac56c..9f0db6ef7 100644
--- a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/policy/ProfileRuleParserTest.java
+++ b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/policy/ProfileRuleParserTest.java
@@ -32,7 +32,7 @@ public class ProfileRuleParserTest extends BaseAttributeFilterParserTest {
/**
* Basic test.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@Test public void policy() throws ComponentInitializationException {
diff --git a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/IssuerNameIDFormatRuleParserTest.java b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/IssuerNameIDFormatRuleParserTest.java
index dda2be06e..d9f7413aa 100644
--- a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/IssuerNameIDFormatRuleParserTest.java
+++ b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/IssuerNameIDFormatRuleParserTest.java
@@ -34,7 +34,7 @@ public class IssuerNameIDFormatRuleParserTest extends BaseAttributeFilterParserT
/**
* Basic test.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@Test public void basic() throws ComponentInitializationException {
final IssuerNameIDFormatExactPolicyRule rule =
diff --git a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterEntityAttributeExactRuleParserTest.java b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterEntityAttributeExactRuleParserTest.java
index 618696d26..2c18dfd19 100644
--- a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterEntityAttributeExactRuleParserTest.java
+++ b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterEntityAttributeExactRuleParserTest.java
@@ -33,7 +33,7 @@ public class ProxiedRequesterEntityAttributeExactRuleParserTest extends BaseAttr
/**
* Basic test.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@Test public void basic() throws ComponentInitializationException {
ProxiedRequesterEntityAttributeExactPolicyRule rule =
diff --git a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterEntityAttributeRegexRuleParserTest.java b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterEntityAttributeRegexRuleParserTest.java
index 7851d1de6..9cb8b7b55 100644
--- a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterEntityAttributeRegexRuleParserTest.java
+++ b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterEntityAttributeRegexRuleParserTest.java
@@ -34,7 +34,7 @@ public class ProxiedRequesterEntityAttributeRegexRuleParserTest extends BaseAtt
/**
* Basic test.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@Test public void basic() throws ComponentInitializationException {
final ProxiedRequesterEntityAttributeRegexPolicyRule rule =
diff --git a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterInEntityGroupRuleParserTest.java b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterInEntityGroupRuleParserTest.java
index cfa7ba0be..437c96784 100644
--- a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterInEntityGroupRuleParserTest.java
+++ b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/ProxiedRequesterInEntityGroupRuleParserTest.java
@@ -23,13 +23,11 @@ import org.springframework.beans.factory.BeanCreationException;
import org.testng.annotations.Test;
import net.shibboleth.idp.attribute.filter.policyrule.saml.impl.ProxiedRequesterInEntityGroupPolicyRule;
+import net.shibboleth.idp.attribute.filter.spring.saml.impl.ProxiedRequesterInEntityGroupRuleParser;
import net.shibboleth.idp.attribute.filter.spring.testing.BaseAttributeFilterParserTest;
import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
-/**
- * test for {@link ProxiedRequesterInEntityGroupRuleParser}.
- */
- at SuppressWarnings("javadoc")
+/** Unit test for {@link ProxiedRequesterInEntityGroupRuleParser}. */
public class ProxiedRequesterInEntityGroupRuleParserTest extends BaseAttributeFilterParserTest {
private void testRule(final String propValue, final boolean result) throws ComponentInitializationException {
@@ -40,14 +38,29 @@ public class ProxiedRequesterInEntityGroupRuleParserTest extends BaseAttributeF
assertEquals(rule.isCheckAffiliations(), result);
}
- @Test(expectedExceptions = {BeanCreationException.class}) public void basic() throws ComponentInitializationException {
+ /**
+ * Failure test.
+ *
+ * @throws ComponentInitializationException on error
+ */
+ @Test(expectedExceptions = {BeanCreationException.class}) public void failure() throws ComponentInitializationException {
testRule("", false);
}
+ /**
+ * Test true outcome.
+ *
+ * @throws ComponentInitializationException on error
+ */
@Test public void egTrue() throws ComponentInitializationException {
testRule("true", true);
}
+ /**
+ * Test false outcome.
+ *
+ * @throws ComponentInitializationException on error
+ */
@Test public void egFalse() throws ComponentInitializationException {
testRule("false", false);
}
diff --git a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterEntityAttributeExactRuleParserTest.java b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterEntityAttributeExactRuleParserTest.java
index a2f67aab3..b1b74f7b4 100644
--- a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterEntityAttributeExactRuleParserTest.java
+++ b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterEntityAttributeExactRuleParserTest.java
@@ -33,7 +33,7 @@ public class RequesterEntityAttributeExactRuleParserTest extends BaseAttributeFi
/**
* Basic test.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@Test public void basic() throws ComponentInitializationException {
RequesterEntityAttributeExactPolicyRule rule =
diff --git a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterEntityAttributeRegexRuleParserTest.java b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterEntityAttributeRegexRuleParserTest.java
index ec94add4c..d65fccf1f 100644
--- a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterEntityAttributeRegexRuleParserTest.java
+++ b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterEntityAttributeRegexRuleParserTest.java
@@ -34,7 +34,7 @@ public class RequesterEntityAttributeRegexRuleParserTest extends BaseAttributeF
/**
* Basic test.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@Test public void basic() throws ComponentInitializationException {
final RequesterEntityAttributeRegexPolicyRule rule = (RequesterEntityAttributeRegexPolicyRule) getPolicyRule("requesterEARegex2.xml");
diff --git a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterNameIDFormatRuleParserTest.java b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterNameIDFormatRuleParserTest.java
index 382e689d5..a1743a78e 100644
--- a/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterNameIDFormatRuleParserTest.java
+++ b/idp-attribute-filter-spring/src/test/java/net/shibboleth/idp/attribute/filter/spring/saml/RequesterNameIDFormatRuleParserTest.java
@@ -34,7 +34,7 @@ public class RequesterNameIDFormatRuleParserTest extends BaseAttributeFilterPars
/**
* Basic test.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@Test public void basic() throws ComponentInitializationException {
final RequesterNameIDFormatExactPolicyRule rule =
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/SelectProfileConfigurationTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/SelectProfileConfigurationTest.java
index 0a7d5c35a..6cda6c363 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/SelectProfileConfigurationTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/SelectProfileConfigurationTest.java
@@ -49,7 +49,7 @@ public class SelectProfileConfigurationTest {
/**
* Test setup.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@BeforeMethod
public void setUp() throws ComponentInitializationException {
diff --git a/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/saml2/profile/impl/AddAuthnRequestTest.java b/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/saml2/profile/impl/AddAuthnRequestTest.java
index c357296cd..0f6617bd9 100644
--- a/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/saml2/profile/impl/AddAuthnRequestTest.java
+++ b/idp-saml-impl/src/test/java/net/shibboleth/idp/saml/saml2/profile/impl/AddAuthnRequestTest.java
@@ -72,7 +72,7 @@ public class AddAuthnRequestTest extends OpenSAMLInitBaseTestCase {
/**
* Set up test state.
*
- * @throws ComponentInitializationException
+ * @throws ComponentInitializationException on error
*/
@BeforeMethod public void setUp() throws ComponentInitializationException {
rc = new RequestContextBuilder().buildRequestContext();
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list