[java-idp-oidc] branch main updated: Adjust some error handling behavior.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=cf0059cc3c5318f72a71582f68601d12e76d7257

The following commit(s) were added to refs/heads/main by this push:
     new cf0059cc Adjust some error handling behavior.
cf0059cc is described below

commit cf0059cc3c5318f72a71582f68601d12e76d7257
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Feb 14 14:07:01 2022 -0500

    Adjust some error handling behavior.
---
 .../op/authn/impl/OIDCClientInfoCredentialValidator.java   | 14 ++------------
 .../idp/flows/authn/OAuth2Client/OAuth2Client-flow.xml     |  1 +
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/authn/impl/OIDCClientInfoCredentialValidator.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/authn/impl/OIDCClientInfoCredentialValidator.java
index b14ff191..c6330a7c 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/authn/impl/OIDCClientInfoCredentialValidator.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/authn/impl/OIDCClientInfoCredentialValidator.java
@@ -111,21 +111,11 @@ public class OIDCClientInfoCredentialValidator extends AbstractUsernamePasswordC
         
         if (clientInformation == null) {
             log.debug("{} OIDC client metadata is missing", getLogPrefix());
-            final LoginException e = new LoginException(AuthnEventIds.UNKNOWN_USERNAME);
-            if (errorHandler != null) { 
-                errorHandler.handleError(profileRequestContext, authenticationContext, e,
-                        AuthnEventIds.UNKNOWN_USERNAME);
-            }
-            throw e;
+            return null;
         } else if (clientInformation.getSecret() == null) {
             log.debug("{} OIDC client metadata for '{}' missing client secret", getLogPrefix(),
                     clientInformation.getID());
-            final LoginException e = new LoginException(AuthnEventIds.NO_CREDENTIALS);
-            if (errorHandler != null) { 
-                errorHandler.handleError(profileRequestContext, authenticationContext, e,
-                        AuthnEventIds.NO_CREDENTIALS);
-            }
-            throw e;
+            return null;
         }
         
         final String username = usernamePasswordContext.getTransformedUsername();
diff --git a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OAuth2Client/OAuth2Client-flow.xml b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OAuth2Client/OAuth2Client-flow.xml
index 73f28100..76c264f8 100644
--- a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OAuth2Client/OAuth2Client-flow.xml
+++ b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OAuth2Client/OAuth2Client-flow.xml
@@ -32,6 +32,7 @@
         <transition on="NoCredentials" to="ReselectFlow" />
         <transition on="InvalidCredentials" to="ReselectFlow" />
         <transition on="RequestUnsupported" to="ReselectFlow" />
+        <transition on="UnknownUsername" to="ReselectFlow" />
     </global-transitions>
 
     <bean-import resource="OAuth2Client-beans.xml" />

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.