[JIRA] (JCOMOIDC-40) Complete OIDCAttributeTranscoder decode values function

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-40 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40?atlOrigin=eyJpIjoiNjQ2ZDdiNTAwMGU1NDM0YWEzYTZkMDNiNWQyZDEzOGQiLCJwIjoiaiJ9 )

Re: Complete OIDCAttributeTranscoder decode values function ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40?atlOrigin=eyJpIjoiNjQ2ZDdiNTAwMGU1NDM0YWEzYTZkMDNiNWQyZDEzOGQiLCJwIjoiaiJ9 )

I’m not sure I quite understand the logic of the AbstractOIDCAttributeTranscoder#doDecode method. The attributeName is taken from the encoded name, which prefixes OIDC to the oidc.name (the claim name). It then uses this as a key to retrieve the value relating to that claim from the JSONObject Map (i.e. input.get(attributeName) ). The claim names in the map will not have this prefix, and no value will be found - unless I am missing a step somewhere.

I suspect the attributeName should be taken from the oidc.name in the transcoding rule properties. But I may be wrong. Any advice Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) is much appreciated.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-40#add-comment?atlOrigin=eyJpIjoiNjQ2ZDdiNTAwMGU1NDM0YWEzYTZkMDNiNWQyZDEzOGQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40#add-comment?atlOrigin=eyJpIjoiNjQ2ZDdiNTAwMGU1NDM0YWEzYTZkMDNiNWQyZDEzOGQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100191- sha1:8f89d94 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220211/89bdaaa3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-306c7d95-db80-4c6a-927f-a70026c60056
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220211/89bdaaa3/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-e067b545-5b2b-4615-812e-fa45f98cbc1b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220211/89bdaaa3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-3e8087a5-6ec8-4777-90d2-bbf980c63726
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220211/89bdaaa3/attachment-0005.png>