[JIRA] (JCOMOIDC-41) Move OIDC Signature Validation resolvers and parameter classes to commons
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Fri Feb 4 13:34:40 UTC 2022
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JCOMOIDC-41 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41?atlOrigin=eyJpIjoiZmNkZDBmYjQyZjc1NDViZTg0NzkxZmNhZmNlMDU5ODYiLCJwIjoiaiJ9 )
Re: Move OIDC Signature Validation resolvers and parameter classes to commons ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41?atlOrigin=eyJpIjoiZmNkZDBmYjQyZjc1NDViZTg0NzkxZmNhZmNlMDU5ODYiLCJwIjoiaiJ9 )
Mechanically it all works, but I think there are some gaps around algorithm allow/deny rules, and mostly it’s just awkward. The missing piece was that we didn’t built OIDC/JWT-aware TrustEngine classes for signature verification. I don’t believe that’s a ton of work, and all the hard stuff is really just reusing or copying bits out of the existing SignatureTrustEngine classes. They’re generic, so the hope was to just plugin a new subclass or two with the SignedJWT type.
That should allows us to switch (with a warning to deployers) the way the extension class for verification is defined over to the TrustEngine-based validation config class rather than the signing class.
But functionally, what’s there now does work, I used it with some trickery to get hold of the IdP’s keys and verify its own tokens.
( https://shibboleth.atlassian.net/browse/JCOMOIDC-41#add-comment?atlOrigin=eyJpIjoiZmNkZDBmYjQyZjc1NDViZTg0NzkxZmNhZmNlMDU5ODYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41#add-comment?atlOrigin=eyJpIjoiZmNkZDBmYjQyZjc1NDViZTg0NzkxZmNhZmNlMDU5ODYiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100191- sha1:7bb8b76 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220204/547e80a1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-2d22261f-9916-4c63-a276-bb7181c4f532
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220204/547e80a1/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-20d92a6e-bb44-4f57-9f19-afc6f0352904
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220204/547e80a1/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-f381f7a9-783e-405e-9f3e-fa405859457e
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220204/547e80a1/attachment-0005.png>
More information about the commits
mailing list