[java-idp-plugin-oidc-rp] branch main updated: Minor Javadoc and fix plugin version to 0.9.0
Phil Smart
philip.smart at jisc.ac.uk
Thu Dec 22 10:20:00 UTC 2022
This is an automated email from the git hooks/post-receive script.
philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.
View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=1c8faa09f0a9dbf888d43c164fd650a3daea1e03
The following commit(s) were added to refs/heads/main by this push:
new 1c8faa0 Minor Javadoc and fix plugin version to 0.9.0
1c8faa0 is described below
commit 1c8faa09f0a9dbf888d43c164fd650a3daea1e03
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Thu Dec 22 10:19:57 2022 +0000
Minor Javadoc and fix plugin version to 0.9.0
---
.../idp/plugin/authn/oidc/rp/context/OAuth2ClientContext.java | 2 +-
.../messaging/context/logic/RequestObjectRequiredAndSupported.java | 2 +-
.../authn/oidc/rp/encoding/impl/AbstractRequestEncoderFunction.java | 6 +++---
.../oidc/rp/impl/AbstractOIDCAuthenticationResponseAction.java | 4 ++--
.../idp/plugin/authn/oidc/rp/impl/AuthorizationController.java | 2 +-
.../plugin/authn/oidc/rp/impl/InitializeRelyingPartyContext.java | 2 +-
.../oidc/rp/impl/RelyingPartyProxySigningParametersResolver.java | 4 ++--
.../authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java | 2 +-
.../net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties | 2 +-
9 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/context/OAuth2ClientContext.java b/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/context/OAuth2ClientContext.java
index 61c14f2..2841ba1 100644
--- a/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/context/OAuth2ClientContext.java
+++ b/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/context/OAuth2ClientContext.java
@@ -32,7 +32,7 @@ import net.shibboleth.utilities.java.support.logic.Constraint;
* with a OpenID Provider.
*
* <p>Typically a subcontext under {@link OIDCPeerEntityContext}, as it relates to the client
- * associated pairwise with the downstream OP peer.</p>
+ * associated pairwise with the upstream OP peer.</p>
*
* @parent {@link OIDCPeerEntityContext}
* @added During an OAuth 2.0 authentication request attempt
diff --git a/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/context/logic/RequestObjectRequiredAndSupported.java b/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/context/logic/RequestObjectRequiredAndSupported.java
index 5b7fc35..b49d1b3 100644
--- a/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/context/logic/RequestObjectRequiredAndSupported.java
+++ b/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/context/logic/RequestObjectRequiredAndSupported.java
@@ -36,7 +36,7 @@ import net.shibboleth.oidc.metadata.context.OIDCProviderMetadataContext;
import net.shibboleth.oidc.profile.config.OIDCAuthorizationConfiguration;
import net.shibboleth.utilities.java.support.logic.Constraint;
-/** Tests whether a request object should be build, and if it is supported by the downstream OP.*/
+/** Tests whether a request object should be build, and if it is supported by the upstream OP.*/
public class RequestObjectRequiredAndSupported extends AbstractRelyingPartyPredicate {
/** Class logger. */
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/AbstractRequestEncoderFunction.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/AbstractRequestEncoderFunction.java
index 3b82e32..77e9e76 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/AbstractRequestEncoderFunction.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/AbstractRequestEncoderFunction.java
@@ -56,7 +56,7 @@ public abstract class AbstractRequestEncoderFunction extends AbstractInitializab
private Function<ProfileRequestContext, OAuth2ClientAuthenticationContext>
oauth2ClientAuthenticationContextLookupStrategy;
- /** OIDC authentication response from downstream OP. */
+ /** OIDC authentication response from upstream OP. */
@Nullable private AuthenticationSuccessResponse authnResponse;
/** OIDC authentication request built by the IdP. */
@@ -67,7 +67,7 @@ public abstract class AbstractRequestEncoderFunction extends AbstractInitializab
/**
* The context used to store client authentication information for communication with a
- * downstream OP.
+ * upstream OP.
*/
@Nullable private OAuth2ClientAuthenticationContext clientAuthnContext;
@@ -112,7 +112,7 @@ public abstract class AbstractRequestEncoderFunction extends AbstractInitializab
}
/**
- * Returns the authentication response from the downstream OP.
+ * Returns the authentication response from the upstream OP.
*
* @return the authentication response.
*/
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AbstractOIDCAuthenticationResponseAction.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AbstractOIDCAuthenticationResponseAction.java
index 9986e3a..36436ad 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AbstractOIDCAuthenticationResponseAction.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AbstractOIDCAuthenticationResponseAction.java
@@ -57,7 +57,7 @@ public abstract class AbstractOIDCAuthenticationResponseAction extends AbstractA
/** Lookup strategy to locate the OP metadata to use.*/
@Nonnull private Function<ProfileRequestContext, OIDCProviderMetadataContext> providerMetadataLookupStrategy;
- /** OIDC authentication response from downstream OP. */
+ /** OIDC authentication response from upstream OP. */
@Nullable private AuthenticationSuccessResponse authnResponse;
/** OIDC authentication request built by the IdP. */
@@ -89,7 +89,7 @@ public abstract class AbstractOIDCAuthenticationResponseAction extends AbstractA
/**
- * Returns the authentication response from the downstream OP. Should never
+ * Returns the authentication response from the upstream OP. Should never
* be {@code null} after {@link #doPreExecute(ProfileRequestContext)} has been called.
*
* @return the authentication response.
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationController.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationController.java
index 707b4aa..b3e5b0b 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationController.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationController.java
@@ -151,7 +151,7 @@ public class AuthorizationController extends AbstractInitializableComponent {
/**
- * Begin an authorization request to the configured downstream OP.
+ * Begin an authorization request to the configured upstream OP.
*
* @param httpRequest the servlet request.
* @param httpResponse the servlet response.
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeRelyingPartyContext.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeRelyingPartyContext.java
index 4d1be9d..93d9289 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeRelyingPartyContext.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeRelyingPartyContext.java
@@ -68,7 +68,7 @@ public class InitializeRelyingPartyContext extends AbstractProfileAction {
/** Strategy used to look up the {@link SAMLPeerEntityContext} to draw from. */
@Nonnull private Function<ProfileRequestContext,OIDCPeerEntityContext> peerEntityContextLookupStrategy;
- /** OIDC issuer id of the downstream OP. */
+ /** OIDC issuer id of the upstream OP. */
@Nullable private String issuerId;
/** Constructor. */
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolver.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolver.java
index 29fc08d..5729c9b 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolver.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolver.java
@@ -52,7 +52,7 @@ import net.shibboleth.utilities.java.support.resolver.CriteriaSet;
* from static credential criterion (e.g. from the reyling party configuration) in addition to the configured signing
* credentials inside the signing configuration (determined by the superclass).
*
- * <p>The downstream OP's metadata is also used to filter for those algorithms supported by the OP in addition to
+ * <p>The upstream OP's metadata is also used to filter for those algorithms supported by the OP in addition to
* those supported by the security configuration.</p>
*
* * <p>
@@ -116,7 +116,7 @@ public class RelyingPartyProxySigningParametersResolver extends BasicJWTSignatur
final List<String> algorithms = getEffectiveSignatureAlgorithms(criteria, includeExcludePredicate);
log.debug("Resolved effectice signature algorithms from config: '{}'", algorithms);
- // Filter by those supported by the downstream OP
+ // Filter by those supported by the upstream OP
final List<String> filteredAlgorithms = filterForProviderSupportedAlgorithms(criteria, algorithms);
final List<JWSAlgorithm> supportedAlgorithms = convertSupportAlgorithmsToJwkAlgorithms(filteredAlgorithms);
log.trace("Resolved effective signature algorithms: {}", supportedAlgorithms);
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java
index 82a967f..74a3155 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java
@@ -81,7 +81,7 @@ public class ValidateAuthenticationResponseResult extends AbstractAuthentication
// TODO: maybe more specific error, and or an error branch in the flow e.g. maybe a UI element?
ActionSupport.buildEvent(profileRequestContext, EventIds.MESSAGE_PROC_ERROR);
} else {
- log.debug("{} Downstream OP signalled a successful response", getLogPrefix());
+ log.debug("{} Upstream OP signalled a successful response", getLogPrefix());
}
}
diff --git a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties
index df37d1b..2bd330d 100644
--- a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties
+++ b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties
@@ -2,7 +2,7 @@
plugin.id = net.shibboleth.idp.plugin.authn.oidc.rp
# Only used when package manifest is not available
-plugin.version = 0.0.1
+plugin.version = 0.9.0
#plugin.license = licence.txt
# No prereqs
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list