[JIRA] (JPAR-205) Account for change to Bouncy Castle artifact name/coordinates
Rod Widdowson (Jira)
jira at shibboleth.atlassian.net
Wed Dec 21 15:39:38 UTC 2022
Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JPAR-205 ( https://shibboleth.atlassian.net/browse/JPAR-205?atlOrigin=eyJpIjoiODhhODkyYmIwNzNlNDkwMTk0NTMxMDI2ZWM4MTNiMDAiLCJwIjoiaiJ9 )
Re: Account for change to Bouncy Castle artifact name/coordinates ( https://shibboleth.atlassian.net/browse/JPAR-205?atlOrigin=eyJpIjoiODhhODkyYmIwNzNlNDkwMTk0NTMxMDI2ZWM4MTNiMDAiLCJwIjoiaiJ9 )
This is mind bendingly complicated.
Both the enforcer & enforcer-data need updated but this can only happen after the parent pom has been updated - this is because the parent pom actually depends on the enforcer. So for release ‘n' the enforcer jars are bound to parent pom ‘n-1'. They will all build and pass the enforcer checks OK because
* The tools (and downloads) are all OK for for that version. Well apart from the versions plugin which isn’t pinned in version ‘n-1’ so that single pom files have to be edited by hand.
* And the build is done into a fresh m2 repo so only those things needed for the build get to go into the repository for checking.
The release process is
* Build & Release enforcer & enforcer data ‘Y' (against parent pom 'N-1’)
* This gives you a non snapshot enforcer and enforcer data to put in the parent pom
* Note that the build itself is being tested by enforcer & data ‘Y-1’.
* Move Release enforcer & enforcer data to ‘Y+1’-SNAPSHOT
* Update the parent pom to point to enforcer and enforcer-data version 'Y'
* Build & Release parent pom N
* and any down stream stuff you need.
* *Now* you can go back and update the parent of enforcer and enforcer-data to version 'N'
I get brain ache every single time that I have to think about this. I usually say “this is rubbish” and update the parent of the enforcers to a SNAPSHOT at least once per release cycle until I re-learn why this doesn’t work - experience its what allows you to spot when you make the same mistake again.
( https://shibboleth.atlassian.net/browse/JPAR-205#add-comment?atlOrigin=eyJpIjoiODhhODkyYmIwNzNlNDkwMTk0NTMxMDI2ZWM4MTNiMDAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JPAR-205#add-comment?atlOrigin=eyJpIjoiODhhODkyYmIwNzNlNDkwMTk0NTMxMDI2ZWM4MTNiMDAiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100213- sha1:d1b903b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221221/fe70dd74/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-28433949-4d64-4629-8963-9c652c9d9f47
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221221/fe70dd74/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-79fdb469-7d6b-41cd-ad6a-0f2b9ae15083
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221221/fe70dd74/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-30dd567b-9773-4a26-8068-ff79ca529d52
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221221/fe70dd74/attachment-0005.png>
More information about the commits
mailing list