[java-oidc-common] branch main updated: Remove acr_values from authn requests that contains a request object

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=f30b45fe9e1bf8544d52f4beab98244ecb1f5add

The following commit(s) were added to refs/heads/main by this push:
     new f30b45f  Remove acr_values from authn requests that contains a request object
f30b45f is described below

commit f30b45fe9e1bf8544d52f4beab98244ecb1f5add
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Dec 20 16:52:24 2022 +0000

    Remove acr_values from authn requests that contains a request object
    
    If the request object and the acr_values param are used together the
    behaviour at the OP is unspecified. Hence, just use the ACR claim in the
    request object.
---
 .../oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java    | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java
index d539d17..774eea2 100644
--- a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java
+++ b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java
@@ -167,14 +167,6 @@ public abstract class AbstractOIDCMessageEncoder extends AbstractHttpServletResp
                 throw new MessageEncodingException("Couldn't serialize request object to JWT: " + e.getMessage(), e);
             }
         }       
-        // This would need to be a requested claim inside the request object, so keep as URL param
-        if (!req.getAcrs().isEmpty()) {  
-            final String acrString =String.join(" ", req.getAcrs()
-                    .stream()
-                    .map(ACR::getValue)
-                    .collect(Collectors.toUnmodifiableList()));
-            params.add(new Pair<>("acr_values", acrString));          
-        }
         
         if (!validateParams(params)) {            
             throw new MessageEncodingException("Authorization parameters are not valid");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.