[JIRA] (IDP-2035) LDAP connection pools are not freeing connections when shut down

[Daniel Fisher (Jira)]

Daniel Fisher ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3A5040b2f7-37ad-4449-b621-76b5c7e66a9d ) *commented* on IDP-2035 ( https://shibboleth.atlassian.net/browse/IDP-2035?atlOrigin=eyJpIjoiN2MyN2IzNzQ3NThkNGQzN2I1MWYyOWVkMzVkMzMwYzUiLCJwIjoiaiJ9 )

Re: LDAP connection pools are not freeing connections when shut down ( https://shibboleth.atlassian.net/browse/IDP-2035?atlOrigin=eyJpIjoiN2MyN2IzNzQ3NThkNGQzN2I1MWYyOWVkMzVkMzMwYzUiLCJwIjoiaiJ9 )

Fix for v5 at: http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commitdiff;h=75126c7a92b503a2eabdcd1479047d4bb1832cbc ( http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commitdiff;h=75126c7a92b503a2eabdcd1479047d4bb1832cbc )

v5 includes an API change to the Validator interface to accept the DataConnector being validated. (Still not completely stateless)

Fix for v4 at: http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commitdiff;h=cdd7299a5a314bcf2166b6d9dd6a605a10a63a35 ( http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commitdiff;h=cdd7299a5a314bcf2166b6d9dd6a605a10a63a35 )

Data connectors pass their resource reference to their validator when the resource setter is called. Bit of a code smell, but I could not find a Spring based solution.

Notable changes for both v4 and v5:

* LDAP and RDBMS validators no longer extend AbstractInitializableComponent
* LDAP and RDBMS data connectors mutate their validators so that throwOnValidatorError = failsFastInitialize during initialize

Note that the LDAP validator defaults throwOnValidatorError to false, while the RDBMS validator default throwOnValidatorError to true. I left that alone, I’m assuming there is some history there I’m unaware of.

( https://shibboleth.atlassian.net/browse/IDP-2035#add-comment?atlOrigin=eyJpIjoiN2MyN2IzNzQ3NThkNGQzN2I1MWYyOWVkMzVkMzMwYzUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2035#add-comment?atlOrigin=eyJpIjoiN2MyN2IzNzQ3NThkNGQzN2I1MWYyOWVkMzVkMzMwYzUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100212- sha1:e2fc486 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221218/5a6895cd/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-38d28074-d2b3-4868-905f-c0c2c1efdc4b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221218/5a6895cd/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-3e3795df-08fc-49f7-86df-ba49680e6cad
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221218/5a6895cd/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-37c51404-10bb-44a4-99ae-0723f62c1d5c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221218/5a6895cd/attachment-0005.png>