[JIRA] (IDP-2056) Incorrect logging in V4Install

[Vladimir Mencl (Jira)]

Vladimir Mencl ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A9e33c654-fa34-43c9-a1c1-fcc1c32d3528 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMzI5MmEyMjM4OWExNDc0ODkwNzZlMTc0NTI5ZTRkMWMiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-2056?atlOrigin=eyJpIjoiMzI5MmEyMjM4OWExNDc0ODkwNzZlMTc0NTI5ZTRkMWMiLCJwIjoiaiJ9 ) IDP-2056 ( https://shibboleth.atlassian.net/browse/IDP-2056?atlOrigin=eyJpIjoiMzI5MmEyMjM4OWExNDc0ODkwNzZlMTc0NTI5ZTRkMWMiLCJwIjoiaiJ9 ) Incorrect logging in V4Install ( https://shibboleth.atlassian.net/browse/IDP-2056?atlOrigin=eyJpIjoiMzI5MmEyMjM4OWExNDc0ODkwNzZlMTc0NTI5ZTRkMWMiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.2.1 Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Components: Installer Created: 16/Dec/22 6:47 AM Priority: Trivial Reporter: Vladimir Mencl ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A9e33c654-fa34-43c9-a1c1-fcc1c32d3528 )

Hi,

These are really minor nits - but once I stumbled upon them, I’m reporting them…

The code in V4Install.generateSealer (around line 742 in idp-installer/src/main/java/net/shibboleth/idp/installer/V4Install.java ) seems to have copy-editing errors resulting from this block being copied over from generateKeyStore just above.

The code logs "Creating backchannel keystore" - even though what is being created is dataSealer key.

The code also logs installerProps.getKeySize() as keySize - even though this value is the RSA key size used elsewhere and is unused here.

As a potential enhancement, the installer might also accept a new property to set the AES key size to use for the dataSealer key (equivalent to --size accepted by seckeygen.sh ) - but I do not see that as crucial.

This issue is just to report the incorrect logging.

Cheers,
Vlad

( https://shibboleth.atlassian.net/browse/IDP-2056#add-comment?atlOrigin=eyJpIjoiMzI5MmEyMjM4OWExNDc0ODkwNzZlMTc0NTI5ZTRkMWMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2056#add-comment?atlOrigin=eyJpIjoiMzI5MmEyMjM4OWExNDc0ODkwNzZlMTc0NTI5ZTRkMWMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100212- sha1:e2fc486 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221216/6b4c6ef3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4848873a-4230-43e8-8ab0-c7f591fd4275
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221216/6b4c6ef3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-5feb3591-1fe9-4536-a42a-a10f19c3bbfc
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221216/6b4c6ef3/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-4dce2ae8-d7f1-4358-995a-9de6b8a37035
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221216/6b4c6ef3/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-e8f2bfd8-e02f-4fe1-9d7b-0f7b5923867f
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221216/6b4c6ef3/attachment-0007.png>