[JIRA] (IDP-2049) Auth validator error handling should classify default event as fallback

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMzMxZTk1NTRlYTFmNGFmOWEzMzY0ZTIxMDA3OWM2N2QiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/IDP-2049?atlOrigin=eyJpIjoiMzMxZTk1NTRlYTFmNGFmOWEzMzY0ZTIxMDA3OWM2N2QiLCJwIjoiaiJ9 ) IDP-2049 ( https://shibboleth.atlassian.net/browse/IDP-2049?atlOrigin=eyJpIjoiMzMxZTk1NTRlYTFmNGFmOWEzMzY0ZTIxMDA3OWM2N2QiLCJwIjoiaiJ9 ) Auth validator error handling should classify default event as fallback ( https://shibboleth.atlassian.net/browse/IDP-2049?atlOrigin=eyJpIjoiMzMxZTk1NTRlYTFmNGFmOWEzMzY0ZTIxMDA3OWM2N2QiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Authentication, Error Handling Created: 07/Dec/22 11:48 AM Fix Versions: 4.3.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

The feature that maps error messages and events to “classified” messages in the AuthenticationErrorContext and AuthenticationWarningContext always had a hole in the logic such that unclassified strings would signal the default/fallback event ID as a flow event, but not actually store off that event ID as a classified message.

This led to a lot of confusing and silly “map InvalidCredentials to InvalidCredentials” mapping rules to drive certain error handling behavior, and it makes auditing the classified messages awkward since null was a common result.

Adding a fallback rule that makes sure the input default event ID is treated as a classified message if nothing else was detected drives the logic more cleanly and eliminates a lot of default mappings. This doesn’t change any flow behavior, but can impact error handling views.

( https://shibboleth.atlassian.net/browse/IDP-2049#add-comment?atlOrigin=eyJpIjoiMzMxZTk1NTRlYTFmNGFmOWEzMzY0ZTIxMDA3OWM2N2QiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2049#add-comment?atlOrigin=eyJpIjoiMzMxZTk1NTRlYTFmNGFmOWEzMzY0ZTIxMDA3OWM2N2QiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100212- sha1:e499055 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221207/badab55a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-cd2eb468-620a-4866-b55c-c99d62bed627
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221207/badab55a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5e57fddd-6e27-4cd8-abe1-936b9d6041ad
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221207/badab55a/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-f36e69ec-dfcd-418d-bbba-a401fafbbd36
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221207/badab55a/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-f67c45ad-f5c2-482b-b5f6-f7f413acd68a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221207/badab55a/attachment-0007.png>