[JIRA] (IDP-2046) Plugin URL resolver does not fall through to backup URLS correctly

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMWFiYzQ0NjRlMzM2NDc5NWI5NzE3ZjZhZjliNTY2ZWUiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-2046?atlOrigin=eyJpIjoiMWFiYzQ0NjRlMzM2NDc5NWI5NzE3ZjZhZjliNTY2ZWUiLCJwIjoiaiJ9 ) IDP-2046 ( https://shibboleth.atlassian.net/browse/IDP-2046?atlOrigin=eyJpIjoiMWFiYzQ0NjRlMzM2NDc5NWI5NzE3ZjZhZjliNTY2ZWUiLCJwIjoiaiJ9 ) Plugin URL resolver does not fall through to backup URLS correctly ( https://shibboleth.atlassian.net/browse/IDP-2046?atlOrigin=eyJpIjoiMWFiYzQ0NjRlMzM2NDc5NWI5NzE3ZjZhZjliNTY2ZWUiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.1.0, 4.2.0 Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Components: Installer Created: 02/Dec/22 11:20 AM Fix Versions: 4.3.0 Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

The code in net.shibboleth.idp.installer.plugin.impl.PluginState and net.shibboleth.idp.installer.plugin.impl.PluginInstallerCLI is miscontructed to put a try around the URL iteration rather than the URL iteration around the try.

This means an exception thrown from URL resolution stops things dead rather than moving on to the next one.

( https://shibboleth.atlassian.net/browse/IDP-2046#add-comment?atlOrigin=eyJpIjoiMWFiYzQ0NjRlMzM2NDc5NWI5NzE3ZjZhZjliNTY2ZWUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2046#add-comment?atlOrigin=eyJpIjoiMWFiYzQ0NjRlMzM2NDc5NWI5NzE3ZjZhZjliNTY2ZWUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100211- sha1:f2d5a0a )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221202/b2aa13ef/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-96978334-1ed2-4f24-9fc7-399b677feef3
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221202/b2aa13ef/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-198ac01a-0ea0-48bf-950e-b901cb4d3a64
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221202/b2aa13ef/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-4adbbb53-4eb1-42d3-a293-d15c4460e7c0
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221202/b2aa13ef/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-84407c6a-bd7e-47b2-a5ca-76a49fce96b6
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221202/b2aa13ef/attachment-0007.png>