[java-idp-plugin-oidc-rp] branch main updated: Fix JWK credentials to publish lookup strategy

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=f1c4b024bd91f0971aa90fa6167bdc3217c65953

The following commit(s) were added to refs/heads/main by this push:
     new f1c4b02  Fix JWK credentials to publish lookup strategy
f1c4b02 is described below

commit f1c4b024bd91f0971aa90fa6167bdc3217c65953
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Dec 2 11:26:18 2022 +0000

    Fix JWK credentials to publish lookup strategy
---
 ...rategy.java => JWKCredentialsToPublishLookupStrategy.java} | 11 ++++++++---
 .../net/shibboleth/idp/flows/oidc/rp/keyset/keyset-beans.xml  |  2 +-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/keyset/impl/RelyingPartyCredentialsToPublishLookupStrategy.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/keyset/impl/JWKCredentialsToPublishLookupStrategy.java
similarity index 82%
rename from idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/keyset/impl/RelyingPartyCredentialsToPublishLookupStrategy.java
rename to idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/keyset/impl/JWKCredentialsToPublishLookupStrategy.java
index 5fee557..638e671 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/keyset/impl/RelyingPartyCredentialsToPublishLookupStrategy.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/keyset/impl/JWKCredentialsToPublishLookupStrategy.java
@@ -26,15 +26,20 @@ import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
 import org.opensaml.security.credential.Credential;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import net.shibboleth.oidc.profile.config.OIDCSecurityConfiguration;
 import net.shibboleth.utilities.java.support.resolver.CriteriaSet;
 import net.shibboleth.utilities.java.support.resolver.ResolverException;
 
 /**
- * Strategy to locate the set of credentials the RP will publish in its KeySet document.
+ * Strategy to locate the set of JWK credentials to publish in its KeySet document.
  */
-public class RelyingPartyCredentialsToPublishLookupStrategy implements Function<OIDCSecurityConfiguration, List<Credential>>{
+public class JWKCredentialsToPublishLookupStrategy implements Function<OIDCSecurityConfiguration, List<Credential>> {
+    
+    /** Class logger. */
+    @Nonnull private final Logger log = LoggerFactory.getLogger(JWKCredentialsToPublishLookupStrategy.class);
 
     @Override
     @Nonnull public List<Credential> apply(@Nullable final OIDCSecurityConfiguration config) {
@@ -53,7 +58,7 @@ public class RelyingPartyCredentialsToPublishLookupStrategy implements Function<
                         config.getJwtDecryptionConfiguration().getKEKCredentialResolver().resolve(new CriteriaSet());
                 resolvedCreds.forEach(credentials::add);
             } catch (final ResolverException e) {
-               e.printStackTrace();
+               log.debug("Unable to resolve decryption credentials", e);
             }
 
         }
diff --git a/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/rp/keyset/keyset-beans.xml b/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/rp/keyset/keyset-beans.xml
index eea7339..8518006 100644
--- a/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/rp/keyset/keyset-beans.xml
+++ b/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/rp/keyset/keyset-beans.xml
@@ -46,7 +46,7 @@
                                                 
                                                 
     <bean id="shibboleth.authn.oidc.rp.keyset.DefaultKeySetCredentialsToPublishLookupStrategy" 
-          class="net.shibboleth.idp.plugin.authn.oidc.rp.keyset.impl.RelyingPartyCredentialsToPublishLookupStrategy"/> 
+          class="net.shibboleth.idp.plugin.authn.oidc.rp.keyset.impl.JWKCredentialsToPublishLookupStrategy"/> 
         
     <bean id="EncodeMessage" class="org.opensaml.profile.action.impl.EncodeMessage" scope="prototype"
         p:messageEncoderFactory-ref="shibboleth.authn.oidc.rp.keyset.messageEncoderFactory"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.