[JIRA] (MDA-269) Some classes are dependent on the default charset

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *created* an issue

Metadata Aggregator ( https://shibboleth.atlassian.net/browse/MDA?atlOrigin=eyJpIjoiYmQxNjUwYjViNjQ4NDBlMjlmYjQ3MDk1N2NmYzVmMDkiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/MDA-269?atlOrigin=eyJpIjoiYmQxNjUwYjViNjQ4NDBlMjlmYjQ3MDk1N2NmYzVmMDkiLCJwIjoiaiJ9 ) MDA-269 ( https://shibboleth.atlassian.net/browse/MDA-269?atlOrigin=eyJpIjoiYmQxNjUwYjViNjQ4NDBlMjlmYjQ3MDk1N2NmYzVmMDkiLCJwIjoiaiJ9 ) Some classes are dependent on the default charset ( https://shibboleth.atlassian.net/browse/MDA-269?atlOrigin=eyJpIjoiYmQxNjUwYjViNjQ4NDBlMjlmYjQ3MDk1N2NmYzVmMDkiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 0.9.2 Assignee: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) Components: Pipeline, SAML Metadata, Validation Created: 26/Aug/22 12:56 PM Fix Versions: 0.10.0 Priority: Trivial Reporter: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 )

SpotBugs observes four places where the code is influenced by the system’s default charset:

* MDQueryMD5ItemIdTransformer
* MDQuerySHA1ItemIdTransformer
* SHA1StringTransformer
* X509RSAOpenSSLBlacklistValidator (reading the blocklist resource)

In each of these cases, we should stabilise behaviour by explicitly using UTF-8 and updating the Javadoc appropriately.

Note that there’s a proposed JSR that will make this the default behaviour of Java at some point in the future, so in my mind this isn’t particularly contentious.

( https://shibboleth.atlassian.net/browse/MDA-269#add-comment?atlOrigin=eyJpIjoiYmQxNjUwYjViNjQ4NDBlMjlmYjQ3MDk1N2NmYzVmMDkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-269#add-comment?atlOrigin=eyJpIjoiYmQxNjUwYjViNjQ4NDBlMjlmYjQ3MDk1N2NmYzVmMDkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100206- sha1:4ed3dc7 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220826/9eefc32b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-3570f1c8-20c7-41c2-8b3a-ce0e3b8c13c7
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220826/9eefc32b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-b7525116-e2d5-4bbe-a253-3f7317249229
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220826/9eefc32b/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-fd8b2b7a-b082-438c-b559-e3a7ba367db4
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220826/9eefc32b/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-f8df0b06-a397-4df4-9eb3-9ca93908e89b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220826/9eefc32b/attachment-0007.png>