[JIRA] (JSPT-98) Integrate lifecycle checking methods in base classes
Ian Young (Jira)
jira at shibboleth.atlassian.net
Thu Aug 25 16:32:41 UTC 2022
Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on JSPT-98 ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiOTlhYWQ3NDEwZDRiNGE5N2IzY2IxYzZmN2UxNjgxMTkiLCJwIjoiaiJ9 )
Re: Integrate lifecycle checking methods in base classes ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiOTlhYWQ3NDEwZDRiNGE5N2IzY2IxYzZmN2UxNjgxMTkiLCJwIjoiaiJ9 )
Turns out that my code was able to make everything final because I didn’t have that hierarchical constraint: my two Base … classes were siblings, one was not a subclass of the other (they were both subclasses of the Abstract … classes, so they were in the same family but maybe… cousins?).
I’ve now pushed appropriate changes to MDA main to adopt the aggregate method names you ended up with, and adjusted my dev/JPAR-186 branch to adapt to that change. Now, in that branch, my intermediate Base … classes are simply empty. Obviously if I ever land that branch, I will abolish those classes and reparent all of the classes that descend from them.
Meanwhile, this issue is done; closing.
( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiOTlhYWQ3NDEwZDRiNGE5N2IzY2IxYzZmN2UxNjgxMTkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiOTlhYWQ3NDEwZDRiNGE5N2IzY2IxYzZmN2UxNjgxMTkiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100206- sha1:9fe2ddf )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220825/e8a093ba/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0f395abe-ac6e-4c09-8de5-906073c7cb27
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220825/e8a093ba/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6e34428e-aa49-44e1-a2b1-d02e5b2e89b4
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220825/e8a093ba/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-72553f90-0cc3-4b04-a0ce-8f5c88953685
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220825/e8a093ba/attachment-0005.png>
More information about the commits
mailing list