[JIRA] (JSPT-98) Integrate lifecycle checking methods in base classes

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on JSPT-98 ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiNzIzZDUyYTA5NWMwNGFkODk1MjAzYWM3NzU5YjgyNDUiLCJwIjoiaiJ9 )

Re: Integrate lifecycle checking methods in base classes ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiNzIzZDUyYTA5NWMwNGFkODk1MjAzYWM3NzU5YjgyNDUiLCJwIjoiaiJ9 )

An observation for Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) and perhaps an implicit suggestion:

In AbstractIdentifiedInitializableComponent , all of the new methods (e.g., ifDestroyedThrowDestroyedComponentException ) are final.

In AbstractInitializableComponent , however, they are not (although for example checkSetterPreconditions is final ).

I’m not sure whether this is because I did it that way in my original code, but it seems sensible to me for all of these things to be final. There’s no reason to expect their definitions to change lower down in the class hierarchy and letting the compiler know this is going to lead to them being optimised more effectively.

Let me know if you’re going to correct this; it influences how I do things downstream a little.

( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiNzIzZDUyYTA5NWMwNGFkODk1MjAzYWM3NzU5YjgyNDUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiNzIzZDUyYTA5NWMwNGFkODk1MjAzYWM3NzU5YjgyNDUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100205- sha1:6417f3f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220818/3c4e3139/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6ba632c8-8b52-4129-ae46-694408ddef34
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220818/3c4e3139/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-bbf78fef-d2b5-4522-a60d-afea0c670350
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220818/3c4e3139/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-27d5711b-764b-47df-a5b4-12b252577aaa
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220818/3c4e3139/attachment-0005.png>