[java-identity-provider] 02/02: IDP-1987 - Review ExtractX509CertificateFromRequest

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=a52b12e4b2372b8e5474b3755b574c7ff31b6756

commit a52b12e4b2372b8e5474b3755b574c7ff31b6756
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Aug 18 09:48:37 2022 -0400

    IDP-1987 - Review ExtractX509CertificateFromRequest
    
    https://shibboleth.atlassian.net/browse/IDP-1987
    
    Reverse X.509 servlet attribute checks.
---
 .../shibboleth/idp/authn/impl/ExtractX509CertificateFromRequest.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractX509CertificateFromRequest.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractX509CertificateFromRequest.java
index efaeea750..6446d9277 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractX509CertificateFromRequest.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractX509CertificateFromRequest.java
@@ -65,9 +65,8 @@ public class ExtractX509CertificateFromRequest extends AbstractExtractionAction
         X509Certificate[] certs =
                 (X509Certificate[]) httpRequest.getAttribute("jakarta.servlet.request.X509Certificate");
         if (certs == null || certs.length == 0) {
-            // Check for newer Jakarta variant.
-            // TODO: Once Jakarta is "common", probably reverse these checks.
-            certs = (X509Certificate[]) httpRequest.getAttribute("jakarta.servlet.request.X509Certificate");
+            // Check for older Java variant (probably moot at this point).
+            certs = (X509Certificate[]) httpRequest.getAttribute("java.servlet.request.X509Certificate");
         }
 
         if (certs == null || certs.length == 0) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.