[java-plugin-storage-jdbc] 01/03: JJDBC-15 PostGreSQL: InputOutputError upon Logout, autoCommit enabled

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-plugin-storage-jdbc.

View the commit online:
http://git.shibboleth.net/view/?p=java-plugin-storage-jdbc.git;a=commit;h=3eaaa25cc2014c3bfc4a7ed87cefd091cd7a93d5

commit 3eaaa25cc2014c3bfc4a7ed87cefd091cd7a93d5
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Fri Aug 12 11:17:29 2022 +0100

    JJDBC-15 PostGreSQL: InputOutputError upon Logout, autoCommit enabled
    
    https://shibboleth.atlassian.net/browse/JJDBC-15
    
    The documentation states that you should not call commit on an autoCommit
    Connections.  So stop doing it.
---
 .../net/shibboleth/plugin/storage/jdbc/impl/JDBCStorageService.java    | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/jdbc-storage-impl/src/main/java/net/shibboleth/plugin/storage/jdbc/impl/JDBCStorageService.java b/jdbc-storage-impl/src/main/java/net/shibboleth/plugin/storage/jdbc/impl/JDBCStorageService.java
index 25b15a6..86c06c0 100644
--- a/jdbc-storage-impl/src/main/java/net/shibboleth/plugin/storage/jdbc/impl/JDBCStorageService.java
+++ b/jdbc-storage-impl/src/main/java/net/shibboleth/plugin/storage/jdbc/impl/JDBCStorageService.java
@@ -952,7 +952,6 @@ public final class JDBCStorageService extends AbstractStorageService implements
                 setExpires(updateStmnt, 2, expires);
                 log.trace("Reap:: '{}':  1: '{}' ; 2: '{}' ;", deleteByContextExpiredSQL, context, expires);
                 updateStmnt.execute();
-                connection.commit();
                 return;
             } catch (final SQLException e) {
                 boolean retry = false;
@@ -992,7 +991,6 @@ public final class JDBCStorageService extends AbstractStorageService implements
                 log.trace("UpdateContextExpiration:: '{}':  1: '{}' ; 2: '{}' ; 3: '{}' ;",
                           updateExpiresByContextSQL, expires, context, newExpires);
                 updateStmnt.execute();
-                connection.commit();
                 return;
             } catch (final SQLException e) {
                 boolean retry = false;
@@ -1028,7 +1026,6 @@ public final class JDBCStorageService extends AbstractStorageService implements
                 log.trace("UpdateContextExpiration:: '{}':  1: '{}'", deleteByContextSQL, context);
 
                 updateStmnt.execute();
-                connection.commit();
                 return;
             } catch (final SQLException e) {
                 boolean retry = false;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.