[JIRA] (JOIDC-125) OIDC Client Information Resolver unknown behaviour

Philip Smart (Jira) jira at shibboleth.atlassian.net
Tue Aug 16 10:51:19 UTC 2022


Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *created* an issue

IdP Plugin - OIDC OP ( https://shibboleth.atlassian.net/browse/JOIDC?atlOrigin=eyJpIjoiMjk4ZGJkMjE0NWM4NGE4NWFiOTcxNzlmNGY0MjE4NjkiLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/JOIDC-125?atlOrigin=eyJpIjoiMjk4ZGJkMjE0NWM4NGE4NWFiOTcxNzlmNGY0MjE4NjkiLCJwIjoiaiJ9 ) JOIDC-125 ( https://shibboleth.atlassian.net/browse/JOIDC-125?atlOrigin=eyJpIjoiMjk4ZGJkMjE0NWM4NGE4NWFiOTcxNzlmNGY0MjE4NjkiLCJwIjoiaiJ9 ) OIDC Client Information Resolver unknown behaviour ( https://shibboleth.atlassian.net/browse/JOIDC-125?atlOrigin=eyJpIjoiMjk4ZGJkMjE0NWM4NGE4NWFiOTcxNzlmNGY0MjE4NjkiLCJwIjoiaiJ9 )

Issue Type: Task Assignee: Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) Created: 16/Aug/22 6:51 AM Priority: Trivial Reporter: Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 )

I am just adding this issue to track my understanding. It does not actually represent a bug of any kind. In the OIDCClientInformationEncryptionParametersResolver, if the EncryptionConfigurationCriterion is not found in the criteriaset it ‘falls back’ to the default behavior of the parent class. However, if that criterion does not exist, to my understanding, the parent class can not process it either. I guess the result is the same, in that no enc. parameters will be returned. Maybe it is just the debug message which is confusing e.g. we do not have that criterion, so nothing can be done, and there is no fallback?

if (!criteria.contains(EncryptionConfigurationCriterion.class)) {
           log.debug("No encryption configuration criterion, falling back to default configuration");
           super.resolveAndPopulateCredentialsAndAlgorithms(params, criteria, whitelistBlacklistPredicate);
           return;
 }

( https://shibboleth.atlassian.net/browse/JOIDC-125#add-comment?atlOrigin=eyJpIjoiMjk4ZGJkMjE0NWM4NGE4NWFiOTcxNzlmNGY0MjE4NjkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-125#add-comment?atlOrigin=eyJpIjoiMjk4ZGJkMjE0NWM4NGE4NWFiOTcxNzlmNGY0MjE4NjkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:f005d5a )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220816/8d456ef0/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5ed9b6f5-00f2-4e35-b763-1b7ba48c1af5
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220816/8d456ef0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-c1c005f8-8b5f-4407-8146-4c9175854538
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220816/8d456ef0/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-71881163-1622-4e68-b3f5-73eda2297e9f
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220816/8d456ef0/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-8b662c55-af88-448c-ab24-7253d089e4cb
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220816/8d456ef0/attachment-0007.png>


More information about the commits mailing list