[JIRA] (JCOMOIDC-41) Move OIDC Signature Validation resolvers and parameter classes to commons

Philip Smart (Jira) jira at shibboleth.atlassian.net
Mon Aug 15 09:50:03 UTC 2022


Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-41 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41?atlOrigin=eyJpIjoiYTc3NTQwODcyOGQ0NDI5ZGJmNzdiZWViZGI4MTBkYTYiLCJwIjoiaiJ9 )

Re: Move OIDC Signature Validation resolvers and parameter classes to commons ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41?atlOrigin=eyJpIjoiYTc3NTQwODcyOGQ0NDI5ZGJmNzdiZWViZGI4MTBkYTYiLCJwIjoiaiJ9 )

Thanks for reviewing.

Yes, the encrypt and signing params were only using a subset of the properties, so I just used the existing classes for the time being. But you are right, those should be JWT specific.

w.r.t. refactoring, I thought it worth checking with you, but also happy to leave them specific to the OIDC/JWT case.

Yes, the RemoteJwkSetCache is injected into places that need ‘jku’ access. This is how the OP currently works, so I used it in similarly in the new resolvers. That might be worth reviewing across OP and RP later on.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-41#add-comment?atlOrigin=eyJpIjoiYTc3NTQwODcyOGQ0NDI5ZGJmNzdiZWViZGI4MTBkYTYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41#add-comment?atlOrigin=eyJpIjoiYTc3NTQwODcyOGQ0NDI5ZGJmNzdiZWViZGI4MTBkYTYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:948b370 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220815/01ce829e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-3ca990c6-813d-497d-a118-b0200d33cda1
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220815/01ce829e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-45aae221-3423-46f6-96a2-2ab64d78b2d7
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220815/01ce829e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-323c2a39-64ba-4536-9ae2-5245c17357d4
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220815/01ce829e/attachment-0005.png>


More information about the commits mailing list