[JIRA] (IDP-1955) Add attachClasses to the maven-war-plugin in idp-parent

[Dan McLaughlin (Jira)]

Dan McLaughlin ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A3a8d6dab-64f5-4a62-a23e-1603099d1796 ) *commented* on IDP-1955 ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiMTdmOGFjNzVhZGU5NDQ3N2FjOWEzNWQ3NTFmYThjZWYiLCJwIjoiaiJ9 )

Re: Add attachClasses to the maven-war-plugin in idp-parent ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiMTdmOGFjNzVhZGU5NDQ3N2FjOWEzNWQ3NTFmYThjZWYiLCJwIjoiaiJ9 )

The only problem with the pom approach is that Maven throws the following warning…

”'dependencies.dependency.scope' for net.shibboleth.idp:idp-war:pom must be one of [provided, compile, runtime, test, system] but is ‘import'. @ line 69, column 14
'dependencies.dependency.scope' for net.shibboleth.idp:idp-war-distribution:pom must be one of [provided, compile, runtime, test, system] but is ‘import'. @ line 82, column 14
It is highly recommended to fix these problems because they threaten the stability of your build.
For this reason, future Maven versions might no longer support building such malformed projects.”

But using a classified artifact just works. I’d still like to have a classified artifact just so I can let Maven handle the dependencies and avoid the Maven warning because I’m try to import a pom that states it’s a war.

Here is another link where someone explains the solution, possibly better than I am. https://www.damirscorner.com/blog/posts/20190614-UsingAWarDependencyInMaven.html ( https://www.damirscorner.com/blog/posts/20190614-UsingAWarDependencyInMaven.html )

( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiMTdmOGFjNzVhZGU5NDQ3N2FjOWEzNWQ3NTFmYThjZWYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiMTdmOGFjNzVhZGU5NDQ3N2FjOWEzNWQ3NTFmYThjZWYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:2343019 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220812/b410f33b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-2e7b62ca-0f9c-432e-9f1b-a9dd8535c9b4
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220812/b410f33b/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-8212a0c3-b992-496f-90ba-a60abe2c2fce
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220812/b410f33b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4b7d0544-df16-45f8-a0a6-176b20af276b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220812/b410f33b/attachment-0005.png>