[java-identity-provider] 09/19: IDP-1793 Use Suppliers for HttpRequest/Response

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch maint-4
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=163984dc4300b00044cd132be7b316a77a791c69

commit 163984dc4300b00044cd132be7b316a77a791c69
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sun Jul 31 13:36:58 2022 +0100

    IDP-1793  Use Suppliers for HttpRequest/Response
    
    https://shibboleth.atlassian.net/browse/IDP-1793
    
    org.opensaml.saml.common.binding.security.impl.BaseSAMLSimpleSignatureSecurityHandler
          and hence
    org.opensaml.saml.saml2.binding.security.impl.SAML2HTTPRedirectDeflateSignatureSecurityHandler
          and
    org.opensaml.saml.saml2.binding.security.impl.SAML2HTTPPostSimpleSignSecurityHandler
    
    lose the setter for the HttpServletRequest and gains a setter for
    a Supplier<HttpServletRequest>
---
 .../resources/net/shibboleth/idp/flows/authn/saml-authn-beans.xml     | 2 +-
 .../main/resources/net/shibboleth/idp/flows/saml/security-beans.xml   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/authn/saml-authn-beans.xml b/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/authn/saml-authn-beans.xml
index 2a3fa770c..dad185f39 100644
--- a/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/authn/saml-authn-beans.xml
+++ b/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/authn/saml-authn-beans.xml
@@ -315,7 +315,7 @@
                             p:clockSkew="%{idp.policy.clockSkew:PT3M}" />
                         <bean class="org.opensaml.saml.common.binding.security.impl.SAMLProtocolMessageXMLSignatureSecurityHandler" scope="prototype" />
                         <bean class="org.opensaml.saml.saml2.binding.security.impl.SAML2HTTPPostSimpleSignSecurityHandler" scope="prototype"
-                            p:httpServletRequest-ref="shibboleth.HttpServletRequest"
+                            p:httpServletRequestSupplier-ref="shibboleth.HttpServletRequestSupplier"
                             p:parser-ref="shibboleth.ParserPool"
                             p:keyInfoResolver-ref="shibboleth.KeyInfoCredentialResolver" />
                         <bean class="org.opensaml.messaging.handler.impl.CheckMandatoryIssuer" scope="prototype"
diff --git a/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/saml/security-beans.xml b/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/saml/security-beans.xml
index fc6f53698..2a2784ad3 100644
--- a/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/saml/security-beans.xml
+++ b/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/saml/security-beans.xml
@@ -139,7 +139,7 @@
             p:activationCondition-ref="NotIgnoreRequestSignaturesPredicate">
         <constructor-arg name="messageHandler">
             <bean class="org.opensaml.saml.saml2.binding.security.impl.SAML2HTTPRedirectDeflateSignatureSecurityHandler" scope="prototype"
-                p:httpServletRequest-ref="shibboleth.HttpServletRequest" />
+                p:httpServletRequestSupplier-ref="shibboleth.HttpServletRequestSupplier" />
         </constructor-arg>
         <property name="errorEvent">
             <util:constant static-field="org.opensaml.profile.action.EventIds.MESSAGE_AUTHN_ERROR" />
@@ -152,7 +152,7 @@
             p:activationCondition-ref="NotIgnoreRequestSignaturesPredicate">
         <constructor-arg name="messageHandler">
             <bean class="org.opensaml.saml.saml2.binding.security.impl.SAML2HTTPPostSimpleSignSecurityHandler" scope="prototype"
-                p:httpServletRequest-ref="shibboleth.HttpServletRequest"
+                p:httpServletRequestSupplier-ref="shibboleth.HttpServletRequestSupplier"
                 p:parser-ref="shibboleth.ParserPool"
                 p:keyInfoResolver-ref="shibboleth.KeyInfoCredentialResolver" />
         </constructor-arg>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.