[JIRA] (IDP-1955) Add attachClasses to the maven-war-plugin in idp-parent

[Dan McLaughlin (Jira)]

Dan McLaughlin ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A3a8d6dab-64f5-4a62-a23e-1603099d1796 ) *commented* on IDP-1955 ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiZTM4NDI2ZDBhYzdhNGUxOTk1MDNhYTg5MTVlMGMwYTEiLCJwIjoiaiJ9 )

Re: Add attachClasses to the maven-war-plugin in idp-parent ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiZTM4NDI2ZDBhYzdhNGUxOTk1MDNhYTg5MTVlMGMwYTEiLCJwIjoiaiJ9 )

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) When you add the attachClasses it just adds a jar as an additional build artifact. It's helpful to have for any WAR module. Yes, the jar maven creates is empty but it includes the pom.xml in the META-INF--Maven can then use that to get the dependencies used for the war and is then able to use Maven dependency management to override dependency versions in the WAR. If you want to add just add it to idp-parent 5.0.0-SNAPSHOT that will work. We are moving all of our projects internally to JakartaEE 9 and I’ll just start using the IDP 5.0 since we aren’t planning to release it for several months. I promise it’s not an accident, it's how Maven works. WARS don’t contain dependency information, only jars do, so if you want to be able to use dependency management in Maven to be able to override dependencies using Maven’s dependency management, then you have to add the attachClasses to the maven-war-plugin so it will include a jar that contains the dependency information.

( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiZTM4NDI2ZDBhYzdhNGUxOTk1MDNhYTg5MTVlMGMwYTEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiZTM4NDI2ZDBhYzdhNGUxOTk1MDNhYTg5MTVlMGMwYTEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:2e7ea99 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220810/c71f83da/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-ccd12343-aa2b-4258-9495-6f3f5708e73d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220810/c71f83da/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-cdec3a4e-938e-455f-b764-55016c34f55c
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220810/c71f83da/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3e25e1a9-21e1-4ec5-82d5-3728339a48f7
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220810/c71f83da/attachment-0005.png>