[java-identity-provider] branch main updated: IDP-1991 - Remove unused HttpServletResponse reference

Scott Cantor cantor.2 at osu.edu
Mon Aug 8 14:54:16 UTC 2022


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=99c110b27c9452d0fa077e98a6d46b917f282b0c

The following commit(s) were added to refs/heads/main by this push:
     new 99c110b27 IDP-1991 - Remove unused HttpServletResponse reference
99c110b27 is described below

commit 99c110b27c9452d0fa077e98a6d46b917f282b0c
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Aug 8 10:54:13 2022 -0400

    IDP-1991 - Remove unused HttpServletResponse reference
    
    https://shibboleth.atlassian.net/browse/IDP-1991
---
 .../net/shibboleth/idp/conf/session-manager-system.xml     |  1 -
 .../idp/session/impl/StorageBackedSessionManager.java      | 14 --------------
 2 files changed, 15 deletions(-)

diff --git a/idp-conf-impl/src/main/resources/net/shibboleth/idp/conf/session-manager-system.xml b/idp-conf-impl/src/main/resources/net/shibboleth/idp/conf/session-manager-system.xml
index c2150b286..5ce32c836 100644
--- a/idp-conf-impl/src/main/resources/net/shibboleth/idp/conf/session-manager-system.xml
+++ b/idp-conf-impl/src/main/resources/net/shibboleth/idp/conf/session-manager-system.xml
@@ -64,7 +64,6 @@
     <bean id="shibboleth.SessionManager" class="net.shibboleth.idp.session.impl.StorageBackedSessionManager"
             depends-on="shibboleth.OpenSAMLConfig"
             p:httpServletRequest-ref="shibboleth.HttpServletRequest"
-            p:httpServletResponse-ref="shibboleth.HttpServletResponse"
             p:authenticationFlowDescriptors="#{@'shibboleth.AuthenticationFlowDescriptorManager'.getComponents()}"
             p:cookieManager-ref="shibboleth.CookieManager"
             p:cookieName="%{idp.session.cookieName:shib_idp_session}"
diff --git a/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java b/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java
index 476f1e48f..698d38ce1 100644
--- a/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java
+++ b/idp-session-impl/src/main/java/net/shibboleth/idp/session/impl/StorageBackedSessionManager.java
@@ -42,7 +42,6 @@ import com.google.common.collect.ImmutableList;
 
 import jakarta.servlet.http.Cookie;
 import jakarta.servlet.http.HttpServletRequest;
-import jakarta.servlet.http.HttpServletResponse;
 import net.shibboleth.idp.authn.AuthenticationFlowDescriptor;
 import net.shibboleth.idp.session.IdPSession;
 import net.shibboleth.idp.session.SPSession;
@@ -122,9 +121,6 @@ public class StorageBackedSessionManager extends AbstractIdentifiableInitializab
     /** Servlet request to read from. */
     @Nullable private HttpServletRequest httpRequest;
 
-    /** Servlet response to write to. */
-    @Nullable private HttpServletResponse httpResponse;
-
     /** Inactivity timeout for sessions. */
     @Nonnull private Duration sessionTimeout;
 
@@ -192,16 +188,6 @@ public class StorageBackedSessionManager extends AbstractIdentifiableInitializab
         httpRequest = request;
     }
 
-    /**
-     * Set the servlet response to write to.
-     * 
-     * @param response servlet response
-     */
-    public void setHttpServletResponse(@Nullable final HttpServletResponse response) {
-        checkSetterPreconditions();
-        httpResponse = response;
-    }
-
     /**
      * Get the session inactivity timeout policy.
      * 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list