[java-support] branch main updated: IDP-1793 Use Suppliers for HttpRequest/Response

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-support.

View the commit online:
http://git.shibboleth.net/view/?p=java-support.git;a=commit;h=aefa8cbabda05517c38c8b4c183449601a10ce2e

The following commit(s) were added to refs/heads/main by this push:
     new aefa8cb  IDP-1793  Use Suppliers for HttpRequest/Response
aefa8cb is described below

commit aefa8cbabda05517c38c8b4c183449601a10ce2e
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sat Aug 6 17:34:49 2022 +0100

    IDP-1793  Use Suppliers for HttpRequest/Response
    
    https://shibboleth.atlassian.net/browse/IDP-1793
    
    Wind back the initializtion test by one step.  Its too aggressive.
---
 .../shibboleth/utilities/java/support/net/CookieManager.java   | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/main/java/net/shibboleth/utilities/java/support/net/CookieManager.java b/src/main/java/net/shibboleth/utilities/java/support/net/CookieManager.java
index 52d6c8f..a8eff62 100644
--- a/src/main/java/net/shibboleth/utilities/java/support/net/CookieManager.java
+++ b/src/main/java/net/shibboleth/utilities/java/support/net/CookieManager.java
@@ -25,17 +25,12 @@ import javax.annotation.Nullable;
 import jakarta.servlet.http.Cookie;
 import jakarta.servlet.http.HttpServletRequest;
 import jakarta.servlet.http.HttpServletResponse;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import net.shibboleth.utilities.java.support.annotation.constraint.NonnullAfterInit;
 import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
 import net.shibboleth.utilities.java.support.component.AbstractInitializableComponent;
 import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
 import net.shibboleth.utilities.java.support.logic.Constraint;
-import net.shibboleth.utilities.java.support.primitive.DeprecationSupport;
 import net.shibboleth.utilities.java.support.primitive.StringSupport;
-import net.shibboleth.utilities.java.support.primitive.DeprecationSupport.ObjectType;
 
 /**
  * A helper class for managing one or more cookies on behalf of a component.
@@ -46,9 +41,6 @@ import net.shibboleth.utilities.java.support.primitive.DeprecationSupport.Object
  */
 public final class CookieManager extends AbstractInitializableComponent {
 
-    /** Log. */
-    private final Logger log = LoggerFactory.getLogger(CookieManager.class);
-
     /** Path of cookie. */
     @Nullable private String cookiePath;
 
@@ -184,7 +176,7 @@ public final class CookieManager extends AbstractInitializableComponent {
     protected void doInitialize() throws ComponentInitializationException {
         super.doInitialize();
         
-        if (getHttpServletRequest() == null || getHttpServletResponse() == null) {
+        if (httpRequestSupplier == null || httpResponseSupplier == null) {
             throw new ComponentInitializationException("Servlet request and response must be set");
         }
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.