[java-opensaml] branch main updated: IDP-1793 Use Suppliers for HttpRequest/Response

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=4706b313f93593f184ac1c3333d8d537c7de9d25

The following commit(s) were added to refs/heads/main by this push:
     new 4706b313f IDP-1793  Use Suppliers for HttpRequest/Response
4706b313f is described below

commit 4706b313f93593f184ac1c3333d8d537c7de9d25
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Fri Aug 5 14:10:52 2022 +0100

    IDP-1793  Use Suppliers for HttpRequest/Response
    
    https://shibboleth.atlassian.net/browse/IDP-1793
    
    As part of the resultant code tidy
    
    1) org.opensaml.saml.saml2.profile.impl.ValidateAssertions
    does not need to manage its own request - it inherits from a class
    that does that already.
    
    2) Make the subclass AssertionValidationInput a static.
---
 .../saml2/profile/impl/ValidateAssertions.java     | 33 ++--------------------
 1 file changed, 2 insertions(+), 31 deletions(-)

diff --git a/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/ValidateAssertions.java b/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/ValidateAssertions.java
index 1b763a41c..bbbb4780e 100644
--- a/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/ValidateAssertions.java
+++ b/opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/ValidateAssertions.java
@@ -60,9 +60,6 @@ public class ValidateAssertions extends AbstractProfileAction {
     /** Class logger. */
     @Nonnull private final Logger log = LoggerFactory.getLogger(ValidateAssertions.class);
     
-    /** The HttpServletRequest being processed. */
-    @NonnullAfterInit private HttpServletRequest httpServletRequest;
-    
     /** Flag which indicates whether a failure of Assertion validation should be considered fatal. */
     private boolean invalidFatal;
     
@@ -141,25 +138,6 @@ public class ValidateAssertions extends AbstractProfileAction {
         validationContextBuilder = builder;
     }
 
-    /**
-     * Get the HTTP servlet request being processed.
-     * 
-     * @return the HTTP servlet request
-     */
-    @NonnullAfterInit public HttpServletRequest getHttpServletRequest() {
-        return httpServletRequest;
-    }
-
-    /**
-     * Set the HTTP servlet request being processed.
-     * 
-     * @param request The HTTP servlet request
-     */
-    public void setHttpServletRequest(@Nonnull final HttpServletRequest request) {
-        checkSetterPreconditions();
-        httpServletRequest = request;
-    }
-    
     /**
      * Get flag which indicates whether a failure of Assertion validation should be considered a fatal processing error.
      * 
@@ -251,13 +229,6 @@ public class ValidateAssertions extends AbstractProfileAction {
         }
     }
 
-    /** {@inheritDoc} */
-    protected void doDestroy() {
-        httpServletRequest = null;
-        
-        super.doDestroy();
-    }
-
     /** {@inheritDoc} */
     protected boolean doPreExecute(@Nonnull final ProfileRequestContext profileRequestContext) {
         if (!super.doPreExecute(profileRequestContext)) {
@@ -402,8 +373,8 @@ public class ValidateAssertions extends AbstractProfileAction {
     /**
      * Class which holds data relevant to validating a SAML 2.0 Assertion.
      */
-    public class AssertionValidationInput {
-        
+    public static class AssertionValidationInput {
+
         /** The profile request context input. */
         private ProfileRequestContext profileContext;
         

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.