[JIRA] (JOIDC-101) TokenDeliveryClaimsClaimsSet class seems unneeded
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Wed Apr 27 13:25:08 UTC 2022
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue
IdP Plugin - OIDC OP ( https://shibboleth.atlassian.net/browse/JOIDC?atlOrigin=eyJpIjoiZjk1ODRiOWU3NjU0NDM2NmJlNGM2MjcwMWM3NTU0NGMiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/JOIDC-101?atlOrigin=eyJpIjoiZjk1ODRiOWU3NjU0NDM2NmJlNGM2MjcwMWM3NTU0NGMiLCJwIjoiaiJ9 ) JOIDC-101 ( https://shibboleth.atlassian.net/browse/JOIDC-101?atlOrigin=eyJpIjoiZjk1ODRiOWU3NjU0NDM2NmJlNGM2MjcwMWM3NTU0NGMiLCJwIjoiaiJ9 ) TokenDeliveryClaimsClaimsSet class seems unneeded ( https://shibboleth.atlassian.net/browse/JOIDC-101?atlOrigin=eyJpIjoiZjk1ODRiOWU3NjU0NDM2NmJlNGM2MjcwMWM3NTU0NGMiLCJwIjoiaiJ9 )
Issue Type: Improvement Assignee: Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) Created: 27/Apr/22 9:25 AM Fix Versions: 3.2.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )
There’s a class in the API module called TokenDeliveryClaimsClaimsSet that doesn’t seem to be exposed via any actual method signature, and just inherits from Nimbus' ClaimSet class with no additional function. Seems to be superfluous, perhaps something that was intended to be extended but never was? Suggest it be removed if so.
( https://shibboleth.atlassian.net/browse/JOIDC-101#add-comment?atlOrigin=eyJpIjoiZjk1ODRiOWU3NjU0NDM2NmJlNGM2MjcwMWM3NTU0NGMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-101#add-comment?atlOrigin=eyJpIjoiZjk1ODRiOWU3NjU0NDM2NmJlNGM2MjcwMWM3NTU0NGMiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100198- sha1:e4e2d96 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220427/6a6bff9d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-9ed5cc9c-0416-479d-a8d1-58ced5b61a13
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220427/6a6bff9d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e17e4a39-1899-4720-be65-bdf13eb5d595
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220427/6a6bff9d/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-5a82da7e-5beb-4051-a5df-80833fa9fe55
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220427/6a6bff9d/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-9afb604b-1cbf-4474-ba82-cabcbc860ab9
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220427/6a6bff9d/attachment-0007.png>
More information about the commits
mailing list