[JIRA] (JMVN-38) Detect missing keyrings - even when artifacts are SNAPSHOT

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Maven Enforcer ( https://shibboleth.atlassian.net/browse/JMVN?atlOrigin=eyJpIjoiMTM0YzdmNGM0NzVmNGZhYzk4MjNiNmQ2NzIzZjY1ZDIiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JMVN-38?atlOrigin=eyJpIjoiMTM0YzdmNGM0NzVmNGZhYzk4MjNiNmQ2NzIzZjY1ZDIiLCJwIjoiaiJ9 ) JMVN-38 ( https://shibboleth.atlassian.net/browse/JMVN-38?atlOrigin=eyJpIjoiMTM0YzdmNGM0NzVmNGZhYzk4MjNiNmQ2NzIzZjY1ZDIiLCJwIjoiaiJ9 ) Detect missing keyrings - even when artifacts are SNAPSHOT ( https://shibboleth.atlassian.net/browse/JMVN-38?atlOrigin=eyJpIjoiMTM0YzdmNGM0NzVmNGZhYzk4MjNiNmQ2NzIzZjY1ZDIiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 3.0, 3,1.0, 3.1.1 Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Created: 18/Apr/22 5:41 AM Fix Versions: 3.1.2 Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

We had multiple occurrences during the 4.2 build marathon (and after) when the build of a plugin failed because this was the first time we had done a release since the enforcer was used and so the artifact generated and signed had no keyring.

CI didn’t detect this because the m2 check doesn’t care about SNAPSHOT jars (because SNAPSHOTS do not have signatures).

We have fixed these all as we hit them (at the cost of multiple maven-enforcer-data-data releases) and it would be nice to detect these in CI.

I believe that the enforcer can be persuaded to do this by not bailing as soon as it sees a snapshot jar. When scanning the M2 folder it knows the group so it could make finding a (non test, non source) jar it should look for the keyring then. Once it has the keyring it can see if the jar is a SNAPSHOT and if so bail.

( https://shibboleth.atlassian.net/browse/JMVN-38#add-comment?atlOrigin=eyJpIjoiMTM0YzdmNGM0NzVmNGZhYzk4MjNiNmQ2NzIzZjY1ZDIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JMVN-38#add-comment?atlOrigin=eyJpIjoiMTM0YzdmNGM0NzVmNGZhYzk4MjNiNmQ2NzIzZjY1ZDIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100198- sha1:943baf4 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220418/f77369f5/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1db2b827-4e5d-4e52-8335-01c48000d7c2
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220418/f77369f5/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-ee18ec82-5a30-473a-ba76-51d5b0475ed2
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220418/f77369f5/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-cd2521e6-1d35-4147-8a5f-0792e1c1f8a4
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220418/f77369f5/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-fa3e47cd-2385-4c9f-ad80-2cc65048ad8b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220418/f77369f5/attachment-0007.png>