[JIRA] (JSPD-1) Build socket server skeleton on top of a Spring ApplicationContext
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Tue Apr 12 19:40:24 UTC 2022
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSPD-1 ( https://shibboleth.atlassian.net/browse/JSPD-1?atlOrigin=eyJpIjoiMDA0NTc5NzQ3ZGQ5NDNkZTkwODAyY2I0MTZhYWE1OGUiLCJwIjoiaiJ9 )
Re: Build socket server skeleton on top of a Spring ApplicationContext ( https://shibboleth.atlassian.net/browse/JSPD-1?atlOrigin=eyJpIjoiMDA0NTc5NzQ3ZGQ5NDNkZTkwODAyY2I0MTZhYWE1OGUiLCJwIjoiaiJ9 )
Aside from that issue, this all looks pretty clean to me. None of the other limitations I read about seem to be a concern. There’s no need to sequence messages that come in from separate connections and any given connection should be used by one client thread at a time to make a request and get a response before any other messages would come in. That fits all the default assumptions.
Given that we can wire all this up easily with a standard Spring approach that will let us reuse everything we have now in the IdP, I can’t see a good reason not to go down this path for now. We can certainly pull in our other Spring ApplicationContext customizations if we want. We might want to wrap the whole thing in a ReloadableService abstraction around the request/response layer so the whole underlying configuration would be reloadable.
Essentially nothing but the core messaging beans would be in the global/root context, and everything else in a child. The activation service can be built to invoke a bean that’s injected as the ReloadableService to call into and do the checkout/return semantic for the locking just like we do for various services now.
( https://shibboleth.atlassian.net/browse/JSPD-1#add-comment?atlOrigin=eyJpIjoiMDA0NTc5NzQ3ZGQ5NDNkZTkwODAyY2I0MTZhYWE1OGUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPD-1#add-comment?atlOrigin=eyJpIjoiMDA0NTc5NzQ3ZGQ5NDNkZTkwODAyY2I0MTZhYWE1OGUiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100198- sha1:943baf4 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220412/eaa9494e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-2ec324f1-04d0-42ae-b831-01d716814a75
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220412/eaa9494e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-6abe24c0-2943-4da7-bdf1-46b64d5e0c25
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220412/eaa9494e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-3f5dac88-d091-40c4-826b-63bc8254412c
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220412/eaa9494e/attachment-0005.png>
More information about the commits
mailing list